Skip to content

fix(sentry): set commits explicitly instead of --auto#1690

Merged
Pascal-Delange merged 1 commit into
mainfrom
fix/sentry-upload-non-fatal
Jun 25, 2026
Merged

fix(sentry): set commits explicitly instead of --auto#1690
Pascal-Delange merged 1 commit into
mainfrom
fix/sentry-upload-non-fatal

Conversation

@Pascal-Delange

@Pascal-Delange Pascal-Delange commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

setCommits: { auto: true } reads commits from a local .git, which is excluded from the Docker build (.dockerignore), so commit association always failed — silently before, and as a hard failure once upload errors were made fatal.

Pass repo + commit (SENTRY_RELEASE) explicitly instead; Sentry resolves it via the GitHub integration with no .git needed. Verified against the real org for both a SHA (staging) and a tag ref (production).

Summary by CodeRabbit

  • Chores
    • Improved release tracking configuration for builds so commits are associated more reliably in deployment environments.
    • Reduced dependence on local repository metadata during containerized builds, helping make builds more consistent.

`setCommits: { auto: true }` reads commits from a local .git, which is
excluded from the Docker build (.dockerignore), so commit association
always failed — silently before, and as a hard failure once upload
errors were made fatal.

Pass repo + commit (SENTRY_RELEASE) explicitly instead; Sentry resolves
it via the GitHub integration with no .git needed. Verified against the
real org for both a SHA (staging) and a tag ref (production).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

@ChibiBlasphem ChibiBlasphem left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@coderabbitai

coderabbitai Bot commented Jun 25, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: d4dc4291-25c7-48b2-8a10-4e089f3efbc6

📥 Commits

Reviewing files that changed from the base of the PR and between 890a507 and f1002f8.

📒 Files selected for processing (1)
  • packages/app-builder/vite.config.ts
📜 Recent review details
⏰ Context from checks skipped due to timeout. (2)
  • GitHub Check: check / main
  • GitHub Check: e2e
🧰 Additional context used
📓 Path-based instructions (1)
packages/**/*.{ts,tsx}

📄 CodeRabbit inference engine (CLAUDE.md)

Use Tailwind CSS 4 with the tailwind-preset package for consistent styling across packages

Files:

  • packages/app-builder/vite.config.ts
🔇 Additional comments (1)
packages/app-builder/vite.config.ts (1)

40-47: LGTM!


📝 Walkthrough

Walkthrough

The Sentry Vite plugin now associates releases with commits using an explicit repository and a commit SHA read from SENTRY_RELEASE, with automatic .git-based lookup disabled.

Changes

Sentry release commit mapping

Layer / File(s) Summary
Explicit commit association
packages/app-builder/vite.config.ts
setCommits now uses auto: false, a fixed repo value, and process.env['SENTRY_RELEASE'] for the commit SHA, with comments explaining the Docker build context.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • checkmarble/marble-frontend#1688 — Also changes packages/app-builder/vite.config.ts around the Sentry Vite plugin, so the configuration path is directly related.

Poem

A commit SHA, now plainly named,
In Docker’s hush, the .git untamed.
Sentry reads the release with grace,
And finds its trail in the proper place.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the main change: replacing Sentry's automatic commit detection with an explicit configuration.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/sentry-upload-non-fatal

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Pascal-Delange Pascal-Delange merged commit 72ad271 into main Jun 25, 2026
7 checks passed
@Pascal-Delange Pascal-Delange deleted the fix/sentry-upload-non-fatal branch June 25, 2026 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants