VRR capable monitor detection (New)#2465
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2465 +/- ##
==========================================
+ Coverage 58.86% 58.94% +0.08%
==========================================
Files 476 477 +1
Lines 48007 48070 +63
Branches 8570 8585 +15
==========================================
+ Hits 28260 28337 +77
+ Misses 18855 18840 -15
- Partials 892 893 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Description
This PR implements a script that can detect whether the DUT is connected to any VRR capable monitors. This is supposed to act as the resource job for
graphics/variable-refresh-rate-manualwhenhas_vrris set to true. See #2464 for more context. #2464 and this PR can be merged in any order, they don't reference each other yet. There will be 1 last PR after this one is merged to put everything together.Resolved issues
#2464 as it is right now doesn't actually check whether the DUT is connected to a VRR capable monitor.
Documentation
The basic idea is to mimic what
modetest -connectorsdoes (this command comes from libdrm-tests).modetestwill print these lines for a VRR capable monitor:If VRR is impossible, this property is either 0 or missing altogether. This script uses the same libdrm API calls to find this value.
The exact lines we are mimicking
Tests
Manually checked the output of this script against GNOME's output in gnome settings.