Skip to content

Add Variable Refresh Rate (VRR) Test (New)#2464

Open
tomli380576 wants to merge 18 commits into
mainfrom
vrr-test-scene
Open

Add Variable Refresh Rate (VRR) Test (New)#2464
tomli380576 wants to merge 18 commits into
mainfrom
vrr-test-scene

Conversation

@tomli380576
Copy link
Copy Markdown
Contributor

@tomli380576 tomli380576 commented Apr 15, 2026

Description

This PR adds a new manual test for the variable refresh rate support that was officially introduced in GNOME 50. The test launches a QT scene with some rectangles bouncing inside the window and the tester is supposed to look at the scene and look for screen tearing.

image

To run this without checkbox, use this command: GALLIUM_HUD=fps MESA_VK_WSI_PRESENT_MODE=relaxed vblank_mode=3 qmlscene vrr_rectangles_test.qml --fullscreen (requires QT installation, or run this inside checkbox.shell)

  • The scene should launch even on xenial
  • If you are running this on 25.10 or older, VRR has to be enabled in this dconf path, log out and back in, then the VRR button will appear in GNOME setting's Display page
image

Resolved issues

Adds coverage for this GNOME feature in 26.04

Documentation

Tbh this is largely experimental, I can only confirm that DUTs with VRR completely working will correctly respond to the requests FPS (i.e. the rectangles and the cursor will look like they are moving at 40fps if the requested FPS is 40).

  1. This test should be run with VSync on, since it doesn't really make sense to go OVER the maximum refresh rate that the display supports
  2. The way FPS changes are "requested" might rely on implicit QT behaviors. There's no explicit method in QML that sets the FPS, so the way it's done here is that we change the rectangle's position on a frame timer. Since there are no changes between each frame (i.e. change only happens every 16ms on 60FPS), QT will know, theoretically, that the scene is static and won't send any draw calls to the GPU. This seems consistent with the fps shown in GALLIUM_HUD.
  3. Right now the test is only controlled by the manifest, but there should be another test that checks whether at least 1 monitor supports VRR. It's implemented in VRR capable monitor detection (New) #2465 (it needs ctypes to do this check which is going to make 2464 too big, hence the separate PR)

Tests

Eyeballs

C3:

@tomli380576 tomli380576 changed the title Add Variable Refresh Rate test (New) Add Variable Refresh Rate (VRR) Test (New) Apr 15, 2026
@tomli380576 tomli380576 requested a review from Copilot April 15, 2026 03:24
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 15, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 58.86%. Comparing base (06722a3) to head (3fb90f6).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2464   +/-   ##
=======================================
  Coverage   58.86%   58.86%           
=======================================
  Files         476      476           
  Lines       48007    48007           
  Branches     8570     8570           
=======================================
  Hits        28260    28260           
  Misses      18855    18855           
  Partials      892      892           
Flag Coverage Δ
provider-base 34.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new manual graphics test intended to validate GNOME 50 Variable Refresh Rate (VRR) behavior by launching a QML/Qt animation and asking the tester to visually check for tearing.

Changes:

  • Added a new graphics/variable-refresh-rate manual job (plus a new manifest entry) to run a QML-based VRR visual test.
  • Added a sample graphics test plan that includes the new VRR job.
  • Added a new QML scene (vrr_rectangles_test.qml) with FPS + rectangle-count controls.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 11 comments.

File Description
providers/base/units/graphics/vrr.yaml Defines the new VRR manual job + introduces a has_vrr_support manifest entry
providers/base/units/graphics/test-plan.pxu Adds a sample test plan intended to include the VRR job
providers/base/data/vrr_rectangles_test.qml New QML fullscreen scene with moving rectangles and FPS control

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread providers/base/data/vrr_rectangles_test.qml Outdated
Comment thread providers/base/data/vrr_rectangles_test.qml Outdated
Comment thread providers/base/units/graphics/vrr.yaml Outdated
Comment thread providers/base/units/graphics/vrr.yaml Outdated
Comment thread providers/base/data/vrr_rectangles_test.qml
Comment thread providers/base/data/vrr_rectangles_test.qml
Comment thread providers/base/units/graphics/vrr.yaml
Comment thread providers/base/units/graphics/test-plan.pxu Outdated
Comment thread providers/base/data/vrr_rectangles_test.qml Outdated
Comment thread providers/base/data/vrr_rectangles_test.qml Outdated
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread providers/base/units/graphics/vrr.yaml
Comment thread providers/base/units/graphics/vrr.yaml
Comment on lines +413 to +417
id: vrr-test-plan
unit: test plan
_name: Sample Variable-Refresh-Rate Test Plan
include:
graphics/variable-refresh-rate.*
Copy link

Copilot AI Apr 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR description says this “adds coverage … in 26.04”, but this new VRR job is only referenced by this standalone “Sample Variable-Refresh-Rate Test Plan” and is not included in the existing 26.04 graphics plans (e.g. graphic-base-26-04-manual). If the intent is to make VRR part of the 26.04 graphics coverage, consider including graphics/variable-refresh-rate in the appropriate existing test plan / nested part (or clarify in the description that it’s intentionally opt-in via this sample plan).

Copilot uses AI. Check for mistakes.
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(leaving this open for visibility before merge)
The test plan will be nested by the 26.04 desktop test plan in the final put-it-all-together PR once the resource job #2465 is landed

@tomli380576 tomli380576 marked this pull request as ready for review April 16, 2026 02:38
@tomli380576
Copy link
Copy Markdown
Contributor Author

Not really sure why the CI says it affects SRU 😿

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants