Add Variable Refresh Rate (VRR) Test (New)#2464
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2464 +/- ##
=======================================
Coverage 58.86% 58.86%
=======================================
Files 476 476
Lines 48007 48007
Branches 8570 8570
=======================================
Hits 28260 28260
Misses 18855 18855
Partials 892 892
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
Adds a new manual graphics test intended to validate GNOME 50 Variable Refresh Rate (VRR) behavior by launching a QML/Qt animation and asking the tester to visually check for tearing.
Changes:
- Added a new
graphics/variable-refresh-ratemanual job (plus a new manifest entry) to run a QML-based VRR visual test. - Added a sample graphics test plan that includes the new VRR job.
- Added a new QML scene (
vrr_rectangles_test.qml) with FPS + rectangle-count controls.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 11 comments.
| File | Description |
|---|---|
| providers/base/units/graphics/vrr.yaml | Defines the new VRR manual job + introduces a has_vrr_support manifest entry |
| providers/base/units/graphics/test-plan.pxu | Adds a sample test plan intended to include the VRR job |
| providers/base/data/vrr_rectangles_test.qml | New QML fullscreen scene with moving rectangles and FPS control |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| id: vrr-test-plan | ||
| unit: test plan | ||
| _name: Sample Variable-Refresh-Rate Test Plan | ||
| include: | ||
| graphics/variable-refresh-rate.* |
There was a problem hiding this comment.
The PR description says this “adds coverage … in 26.04”, but this new VRR job is only referenced by this standalone “Sample Variable-Refresh-Rate Test Plan” and is not included in the existing 26.04 graphics plans (e.g. graphic-base-26-04-manual). If the intent is to make VRR part of the 26.04 graphics coverage, consider including graphics/variable-refresh-rate in the appropriate existing test plan / nested part (or clarify in the description that it’s intentionally opt-in via this sample plan).
There was a problem hiding this comment.
(leaving this open for visibility before merge)
The test plan will be nested by the 26.04 desktop test plan in the final put-it-all-together PR once the resource job #2465 is landed
|
Not really sure why the CI says it affects SRU 😿 |
Description
This PR adds a new manual test for the variable refresh rate support that was officially introduced in GNOME 50. The test launches a QT scene with some rectangles bouncing inside the window and the tester is supposed to look at the scene and look for screen tearing.
To run this without checkbox, use this command:
GALLIUM_HUD=fps MESA_VK_WSI_PRESENT_MODE=relaxed vblank_mode=3 qmlscene vrr_rectangles_test.qml --fullscreen(requires QT installation, or run this inside checkbox.shell)Resolved issues
Adds coverage for this GNOME feature in 26.04
Documentation
Tbh this is largely experimental, I can only confirm that DUTs with VRR completely working will correctly respond to the requests FPS (i.e. the rectangles and the cursor will look like they are moving at 40fps if the requested FPS is 40).
Tests
Eyeballs
C3: