Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/gradle-plugin-lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -32,9 +32,9 @@ jobs:
${{ runner.os }}-gradle-

- name: Run Detekt
working-directory: gradle-plugins/react
run: ./gradlew :brownfield:detekt --no-daemon --stacktrace
working-directory: gradle-plugins/react/brownfield
run: ./gradlew detekt --no-daemon --stacktrace

- name: Run KtLint
working-directory: gradle-plugins/react
run: ./gradlew :brownfield:ktlintCheck --no-daemon --stacktrace
working-directory: gradle-plugins/react/brownfield
run: ./gradlew ktlintCheck --no-daemon --stacktrace
4 changes: 2 additions & 2 deletions .github/workflows/release-brownfield-gradle-plugin.yml
Original file line number Diff line number Diff line change
Expand Up @@ -97,9 +97,9 @@ jobs:
--output out/jreleaser/brownfield-gradle-plugin-release-notes.md

- name: Stage Maven release artifacts
working-directory: gradle-plugins/react
working-directory: gradle-plugins/react/brownfield
run: |
./gradlew :brownfield:publishMavenLocalPublicationToReleaseStagingRepository \
./gradlew publishMavenLocalPublicationToReleaseStagingRepository \
-PSkipSigning=true \
--no-daemon \
--stacktrace
Expand Down
6 changes: 3 additions & 3 deletions gradle-plugins/publish-to-maven-local.sh
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,13 @@

set -e

cd ./gradle-plugins/react
cd ./gradle-plugins/react/brownfield
./gradlew clean

if [ "$1" == "--skip-signing" ]; then
./gradlew build
./gradlew :brownfield:publishMavenLocalPublicationToMavenLocalRepository -PSkipSigning=true -PIS_SNAPSHOT=true
./gradlew publishMavenLocalPublicationToMavenLocalRepository -PSkipSigning=true -PIS_SNAPSHOT=true
else
./gradlew build
./gradlew :brownfield:publishMavenLocalPublicationToMavenLocalRepository
./gradlew publishMavenLocalPublicationToMavenLocalRepository
fi
2 changes: 1 addition & 1 deletion gradle-plugins/react/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,7 @@ reactBrownfield {
## Tooling

- We are using `ktlint` and `detekt` for formatting and linting
- You can run `./gradlew :brownfield:lint` to auto-format and detect linting issues, or use the root workspace script `yarn run gradle-plugin:lint`
- You can run `./brownfield/gradlew -p brownfield detekt ktlintFormat` to auto-format and detect linting issues, or use the root workspace script `yarn run gradle-plugin:lint`
- Maintainers should use [PUBLISHING.md](./PUBLISHING.md) for the release workflow, release notes generation, and Maven Central publication process

## Architecture
Expand Down
File renamed without changes.
7 changes: 0 additions & 7 deletions gradle-plugins/react/brownfield/settings.gradle

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ import com.callstack.react.brownfield.processors.VariantTaskProvider
import com.callstack.react.brownfield.shared.BaseProject
import com.callstack.react.brownfield.shared.GradleProps
import com.callstack.react.brownfield.utils.Extension
import com.callstack.react.brownfield.utils.Utils
import org.gradle.api.ProjectConfigurationException
import org.gradle.api.artifacts.Configuration
import org.gradle.api.artifacts.ResolvedArtifact
Expand Down Expand Up @@ -53,14 +52,6 @@ class ArtifactsResolver(
}

private fun embedExpoDependencies() {
/**
* expo project does not exist in example-android-library so doing an
* early exit.
*/
if (Utils.isExampleLibrary(baseProject.project.name)) {
return
}

/**
* The expo third party dependencies are linked to `expo` project.
* They are linked via `api` configuration and in two ways. In the
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,15 +23,6 @@ object RNSourceSets {
project: Project,
extension: Extension,
) {
/**
* Do not configure sourceSets for our example library.
* The reason is that we expect some RN specific tasks to
* be present on the consuming library, which is not the case
* with our example library.
*/
if (Utils.isExampleLibrary(project.name)) {
return
}
this.project = project
this.extension = extension

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -39,10 +39,6 @@ object Utils {
}
}

fun isExampleLibrary(projectName: String): Boolean {
return projectName == "example-android-library"
}

fun isExpoProject(project: Project): Boolean {
return project.findProject(EXPO_PROJECT_LOCATOR) != null
}
Expand Down
46 changes: 0 additions & 46 deletions gradle-plugins/react/example-android-library/build.gradle.kts

This file was deleted.

This file was deleted.

2 changes: 1 addition & 1 deletion gradle-plugins/react/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,6 @@
"version": "0.0.1",
"private": true,
"scripts": {
"gradle-plugin:lint": "./gradlew :brownfield:detekt :brownfield:ktlintFormat"
"gradle-plugin:lint": "./brownfield/gradlew -p brownfield detekt ktlintFormat"
}
}
15 changes: 0 additions & 15 deletions gradle-plugins/react/settings.gradle.kts

This file was deleted.

Loading