Skip to content

refactor: remove example library from brownfield gradle plugin#366

Merged
hurali97 merged 2 commits into
mainfrom
refactor/remove-example-lib-bgp
Jun 10, 2026
Merged

refactor: remove example library from brownfield gradle plugin#366
hurali97 merged 2 commits into
mainfrom
refactor/remove-example-lib-bgp

Conversation

@hurali97

Copy link
Copy Markdown
Member

Summary

This removes the example-android-library from brownfield-gradle-plugin testing scope. The reason is the added maintenance with quite little value and we have already testing in place with using local maven published brownfield-gradle-plugin on CI and locally with Expo and RN Apps.

Test plan

  • CI Passes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the example-android-library from the Brownfield Gradle plugin’s local test/build scope and updates tooling/CI to run the plugin directly from gradle-plugins/react/brownfield (including adding a dedicated Gradle wrapper and version catalog there).

Changes:

  • Delete the example-android-library module and related “example-only” conditionals in the plugin code.
  • Make gradle-plugins/react/brownfield self-contained for running Gradle tasks (Gradle wrapper + gradle/libs.versions.toml) and update Yarn scripts/docs accordingly.
  • Update GitHub Actions workflows and publishing script paths to run Gradle from gradle-plugins/react/brownfield.

Reviewed changes

Copilot reviewed 12 out of 17 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
gradle-plugins/react/settings.gradle.kts Removes the old composite/example Gradle setup for the react plugin workspace.
gradle-plugins/react/README.md Updates local lint command documentation (now intended to run via brownfield/gradlew).
gradle-plugins/react/package.json Updates the lint script to invoke the plugin build directly from brownfield.
gradle-plugins/react/example-android-library/src/main/kotlin/com/callstack/example/Library.kt Removes the example library source.
gradle-plugins/react/example-android-library/build.gradle.kts Removes the example library Gradle build file.
gradle-plugins/react/brownfield/src/main/kotlin/com/callstack/react/brownfield/utils/Utils.kt Removes example-library detection helper.
gradle-plugins/react/brownfield/src/main/kotlin/com/callstack/react/brownfield/plugin/RNSourceSets.kt Removes early-exit that skipped configuration for the example library.
gradle-plugins/react/brownfield/src/main/kotlin/com/callstack/react/brownfield/artifacts/ArtifactsResolver.kt Removes example-library early-exit for Expo embedding logic.
gradle-plugins/react/brownfield/settings.gradle Removes settings-level version catalog configuration (replaced by local catalog file).
gradle-plugins/react/brownfield/gradlew.bat Adds Windows Gradle wrapper script for the standalone plugin project.
gradle-plugins/react/brownfield/gradlew Adds POSIX Gradle wrapper script for the standalone plugin project.
gradle-plugins/react/brownfield/gradle/wrapper/gradle-wrapper.properties Adds Gradle wrapper distribution configuration.
gradle-plugins/react/brownfield/gradle/wrapper/gradle-wrapper.jar Adds the Gradle wrapper JAR.
gradle-plugins/react/brownfield/gradle/libs.versions.toml Adds a local version catalog for the standalone plugin project.
gradle-plugins/publish-to-maven-local.sh Runs publishing from gradle-plugins/react/brownfield and updates task paths.
.github/workflows/release-brownfield-gradle-plugin.yml Updates working directory and publish task invocation for release staging.
.github/workflows/gradle-plugin-lint.yml Updates working directory and task invocation for detekt/ktlint in CI.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread gradle-plugins/react/README.md Outdated
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@hurali97 hurali97 merged commit a07db9e into main Jun 10, 2026
6 checks passed
@hurali97 hurali97 deleted the refactor/remove-example-lib-bgp branch June 10, 2026 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants