refactor: remove example library from brownfield gradle plugin#366
Merged
Conversation
artus9033
approved these changes
Jun 10, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the example-android-library from the Brownfield Gradle plugin’s local test/build scope and updates tooling/CI to run the plugin directly from gradle-plugins/react/brownfield (including adding a dedicated Gradle wrapper and version catalog there).
Changes:
- Delete the
example-android-librarymodule and related “example-only” conditionals in the plugin code. - Make
gradle-plugins/react/brownfieldself-contained for running Gradle tasks (Gradle wrapper +gradle/libs.versions.toml) and update Yarn scripts/docs accordingly. - Update GitHub Actions workflows and publishing script paths to run Gradle from
gradle-plugins/react/brownfield.
Reviewed changes
Copilot reviewed 12 out of 17 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| gradle-plugins/react/settings.gradle.kts | Removes the old composite/example Gradle setup for the react plugin workspace. |
| gradle-plugins/react/README.md | Updates local lint command documentation (now intended to run via brownfield/gradlew). |
| gradle-plugins/react/package.json | Updates the lint script to invoke the plugin build directly from brownfield. |
| gradle-plugins/react/example-android-library/src/main/kotlin/com/callstack/example/Library.kt | Removes the example library source. |
| gradle-plugins/react/example-android-library/build.gradle.kts | Removes the example library Gradle build file. |
| gradle-plugins/react/brownfield/src/main/kotlin/com/callstack/react/brownfield/utils/Utils.kt | Removes example-library detection helper. |
| gradle-plugins/react/brownfield/src/main/kotlin/com/callstack/react/brownfield/plugin/RNSourceSets.kt | Removes early-exit that skipped configuration for the example library. |
| gradle-plugins/react/brownfield/src/main/kotlin/com/callstack/react/brownfield/artifacts/ArtifactsResolver.kt | Removes example-library early-exit for Expo embedding logic. |
| gradle-plugins/react/brownfield/settings.gradle | Removes settings-level version catalog configuration (replaced by local catalog file). |
| gradle-plugins/react/brownfield/gradlew.bat | Adds Windows Gradle wrapper script for the standalone plugin project. |
| gradle-plugins/react/brownfield/gradlew | Adds POSIX Gradle wrapper script for the standalone plugin project. |
| gradle-plugins/react/brownfield/gradle/wrapper/gradle-wrapper.properties | Adds Gradle wrapper distribution configuration. |
| gradle-plugins/react/brownfield/gradle/wrapper/gradle-wrapper.jar | Adds the Gradle wrapper JAR. |
| gradle-plugins/react/brownfield/gradle/libs.versions.toml | Adds a local version catalog for the standalone plugin project. |
| gradle-plugins/publish-to-maven-local.sh | Runs publishing from gradle-plugins/react/brownfield and updates task paths. |
| .github/workflows/release-brownfield-gradle-plugin.yml | Updates working directory and publish task invocation for release staging. |
| .github/workflows/gradle-plugin-lint.yml | Updates working directory and task invocation for detekt/ktlint in CI. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This removes the
example-android-libraryfrombrownfield-gradle-plugintesting scope. The reason is the added maintenance with quite little value and we have already testing in place with using local maven publishedbrownfield-gradle-pluginon CI and locally with Expo and RN Apps.Test plan