Skip to content

check if cb doesnt exist #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vishalbasra wants to merge 3 commits into
base: master
Choose a base branch
from
Open

check if cb doesnt exist #16

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
58d7df3
check if cb doesnt exist
vishalbasra May 30, 2018
7c6d0a8
Merge branch 'master' of git://github.com/brentm5/knife-chef-inventory
vishalbasra Jun 11, 2018
6b18a20
some rubocop fixes
vishalbasra Jun 11, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/chef/knife/inventory_chef_client.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ def search_args
rows: max_results,
filter_result: {
name: ["name"],
chef_version: %w[chef_packages chef version],
chef_version: %w(chef_packages chef version),
ohai_time: ["ohai_time"]
}
}
Expand Down
12 changes: 10 additions & 2 deletions lib/chef/knife/inventory_cookbook.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,16 @@ def run
@cookbook_version = name_args[1]
@show_env_constraints = config[:env_constraints]

unless @cookbook_name
ui.error "You need to specify a cookbook"
if @cookbook_name
cookbook_object = search_nodes("cookbooks_#{@cookbook_name}:*")
if cookbook_object.to_s == "[]"
ui.fatal "The cookbook name you provided #{cookbook_name} does not exist on the Chef server."
show_usage
exit 1
end
else
ui.fatal "You did not specify a cookbook. You need to specify a cookbook."
show_usage
exit 1
end

Expand Down
6 changes: 3 additions & 3 deletions tasks/changelog.rake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,9 @@ begin
GitHubChangelogGenerator::RakeTask.new :changelog do |config|
config.future_release = "v#{Knife::ChefInventory::VERSION}"
config.issues = false
config.enhancement_labels = %w[enhancement]
config.bug_labels = %w[bug]
config.exclude_labels = %w[no_changelog]
config.enhancement_labels = %w(enhancement)
config.bug_labels = %w(bug)
config.exclude_labels = %w(no_changelog)
end
rescue LoadError
puts "Problem loading gems please install chef and github_changelog_generator"
Expand Down