check if cb doesnt exist - #16
Open
vishalbasra wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based off of #5
If the cookbook doesn't exist, the object which forms as a result of this query / api call
search_nodes("cookbooks_#{@cookbook_name}:*") is []
I tried comparing it to nil ( because that's what i think is going on here) and other things but i couldn't get it to work ( ruby noob )
comparing against a string '[]' works and if the cookbook wasn't found, we error out and exit.
I dunno if we have to run like a lintt status checker, update the gem version etc. etc. cause this is the first time I'm doing this, but I think we might have to, let me know!