fix: check response.ok when saving variant storage setting#485
Merged
Conversation
fetch() doesn't reject on HTTP 4xx/5xx, so a failed PUT to /api/v1/settings/variant-storage would still toast "success". For this setting that's especially misleading: the admin thinks they selected S3/R2 while variant_storage stays empty, variantBaseUrl is blank, and backfill can't run. Throw on !res.ok so it routes to the updateFailed toast. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Post-merge review of #483 (raised by both @Picimpact-Design design review and @Picimpact-Review code review):
variant-storage-card.tsx'ssave()didawait fetch(PUT)then always toasted success.fetchdoesn't reject on 4xx/5xx, so a failed PUT wrongly reports success — and for this setting that's especially misleading: the admin believes they selected S3/R2 whilevariant_storagestays empty,variantBaseUrlis blank, and the backfill can't run.Fix
Capture the response and
throwon!res.okso it routes to the existingConfig.updateFailedtoast.Verification
pnpm lint— 0 errors.npx tsc --noEmit— no errors invariant-storage-card.tsx.🤖 Generated with Claude Code