fix(settings): check res.ok in variant-storage save (FU-5)#486
Closed
Zheaoli wants to merge 1 commit into
Closed
Conversation
Per FE review: the save handler toasted success even on HTTP 4xx/5xx (fetch does not throw on error status). Check res.ok and throw so it falls through to the updateFailed toast. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: variant-storage save falsely toasted success on HTTP error
Post-merge follow-up to #483 (flagged by both @Picimpact-Design and @Picimpact-Review).
variant-storage-card.tsx'ssave()toasted success even on HTTP 4xx/5xx, becausefetchdoesn't throw on error status. For this feature that has real UX cost: an admin could believe they set the backend to S3/R2 while the PUT actually failed, then be confused whenvariantBaseUrlstays empty and backfill produces nothing.Change
One line: check
res.okafter the PUT and throw so it falls through to theupdateFailedtoast.Verification
tsc --noEmit+eslintclean. Diff is the singlesave()change.(Addresses task #14 / FU-5 — I'd already applied + pushed this when the task was created, so opening it here to avoid duplicate work.)
🤖 Generated with Claude Code