test(ELITEA-1739): search skills by name (skills module, first case) - #130
Merged
Conversation
… (tests/skills.spec.ts) Greenfield skills module: adds SkillFormPage/SkillsListPage page objects and the ELITEA-1739 search-by-name test, per the re-verified AFS (Enter-key required to trigger the main list filter, not fill() alone). Bundles the analyst's AFS file into this PR per workflow convention.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
skillsmodule's first automated spec (tests/skills.spec.ts), per the re-verified AFS attest-specs/skills/l3_search-skills-by-name_ELITEA-1739.md.tests/pages/skillForm.page.ts(create-form) andtests/pages/skillsList.page.ts(list/search) — greenfield module, no priorskillstest surface existed.Enteris pressed post-fill()—fill()alone only opens a typeahead tooltip. Both phases are asserted separately (step 7 pre-Enter, step 7b post-Enter).ensureSkillsExist()checks for each of the 3 slug-valid skill names (formatter/code-reviewer/content-writer) before creating it, since the account may already carry them from an earlier analyst pass.test-specs/skills/l3_search-skills-by-name_ELITEA-1739.md) into this PR, since it was left uncommitted on disk per the analyst's own dispatch instruction.Implementer-side fixes found during Phase 4/5 (infrastructure, not product defects)
browser.newContext({ storageState })— the worker-scoped fixture's own dismissal (done in the login context) doesn't reliably carry over. Fixed withgotoSkillsListViaSidebar()(dismiss-then-click, with one retry if diverted to/app/onboarding).ensureSkillsExist()originally raced a bare.count()immediately afterpage.goto(), misdetecting an existing "formatter" skill as missing and creating a live duplicate (caught, and the duplicate manually deleted via the confirmed Skills delete-confirmation dialog, before re-running). Fixed by waiting for the authoritativeGET .../skills/prompt_lib/...list response before checking.Flagged for Tal (not actioned in this PR)
trackConsoleErrors()is now duplicated in a 6th spec file, past.agents/testing.md's own "do not let a 6th module land before this happens" note on the deferred shared-fixture extraction (tests/fixtures/auth.ts+ console-tracking helper). Framework-architecture decision, left for a dedicated framework-scale PR per Hard Rule (implementer executes plans, doesn't invent them).Test plan
npx playwright test --grep "ELITEA-1739"— green 3/3 consecutive local runs, no flake..agents/testing.md: "no CI yet ... 'CI' and 'local' are the same command").Refs #127