Skip to content

fix FBA outbound shipping#68

Closed
florianbepunkt wants to merge 3 commits into
beardon:masterfrom
florianbepunkt:master
Closed

fix FBA outbound shipping#68
florianbepunkt wants to merge 3 commits into
beardon:masterfrom
florianbepunkt:master

Conversation

@florianbepunkt

Copy link
Copy Markdown

fixes mws.FulfillmentOutboundShipment.CreateFulfillmentOrder(), moved the parameter conversion necessary for FBA into the request function

@florianbepunkt

Copy link
Copy Markdown
Author

please ignore the first commit, messed something up. second commit should be good for review.

@dciccale

dciccale commented May 8, 2017

Copy link
Copy Markdown
Collaborator

@florianbepunkt why there are 23 files marked as changed when there were actually only 2 changed? I think it could be a line ending change, but not sure. Are you using some git client?

Please correct the issue, or open a new PR with only the changes you meant to do.

@florianbepunkt

Copy link
Copy Markdown
Author

@dciccale using the github desktop client on mac os, so yes, probably a line ending issue. I'll try to correct it when I have more time but it may be a while I'm afraid

@matheusvellone

Copy link
Copy Markdown

Looks like it's related to file permissions that were 644 and was replaced with 777 when commited.
Changing them back to 644 with a chmod -R 644 <project-dir> should fix their permissions and may not be listed as a file changed

@WeeJeWel

WeeJeWel commented Jan 4, 2018

Copy link
Copy Markdown

@florianbepunkt Thank you for your work, the code works very well in my implementation!

I hope this PR can be merged eventually, because now we have to resort to linking a github repo in the package.json, which feels... dirty.

@florianbepunkt

Copy link
Copy Markdown
Author

@WeeJeWel you're welcome. although I would recommend using PR #98

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants