outbound shipping (FBA) example

[florianbepunkt]

any chance to get an example hwo to send a outbound shipping (fba) feed with items? I really struggle with the code so far and can't find a full example.

EDITED for clarity

[florianbepunkt]

so far this is what I have

function testOutbound(order) {
    return this.mws.FulfillmentOutboundShipment.CreateFulfillmentOrder({
      SellerFulfillmentOrderId: order.id,
      ShippingSpeedCategory: 'Standard',
      DisplayableOrderId: order.id,
      DisplayableOrderDateTime: moment(order.invoiceDate).format(),
      DisplayableOrderComment: '',
      FulfillmentPolicy: 'FillOrKill',
      DestName: order.shippingAddress.name,
      DestAddressLine1: order.shippingAddress.address1,
      DestAddressLine2: order.shippingAddress.address2,
      DestCity: order.shippingAddress.city,
      DestPostalCode: order.shippingAddress.postalcode,
      DestCountryCode: order.shippingAddress.countryCode ,
      LineItems: [{
        DisplayableComment: '',
        GiftMessage: '',
        Quantity: 1,
        SellerFulfillmentOrderItemId: 'abcdefg',
        SellerSKU: 'CM01-FBA'
      }]
    })
  }

this gives me the following Error: The request signature we calculated does not match the signature you provided. Check your AWS Secret Access Key and signing method. Consult the service documentation for details. which is rather strange since I use this lib successfully in the same project with the same credentials to get orders.

I'm not sure if I set the paramters right, especially when it comes to the line items (guees work on my side). Also I know that coming from the official Amazon PHP library that you need to set the SellerId as a paramter when you create a OutboundShipping request.

[tyscorp]

I have never actually used and have no way to test the FBA parts of this library because Amazon doesn't have a testing environment for MWS.

I'm guessing the signature error is a misdirect and the real error is how LineItems is being handled. The library I based this off has a weird way of representing it and I never really fixed it because it has never been needed by my employer.

I don't think I'll really have any time soon to look at this. For now, you could debug this issue by monkey-patching the request function like so:

var request = mws.request;
mws.request = function (req, q, meta) {
    // modify `q` here to add LineItems
    q['Items.member.1.DisplayableComment'] = '';
    q['Items.member.1.GiftMessage'] = '';
    q['Items.member.1.Quantity'] = 1;
    q['Items.member.1.SellerFulfillmentOrderItemId'] = 'abcdefg';
    q['Items.member.1.SellerSKU'] = 'CM01-FBA';
    return request(req, q, meta);
};

If you wanted to submit a proper fix I'd be happy to review/merge it.

[florianbepunkt]

Okay, I tried to kind of re-engineer the repo you based this on to figure out the original intention… IMHO this whole parameter renaming thing coming from the base repo is a bit messy and I can't see the reason behind it, but getting rid of it would mean a lot of refactoring.

The way you refactored the code makes the code a lot cleaner and works for all use cases except the lists (Type.COMPLEX) since it messes with the list renaming/reordering that needs to take place. Do you use Type.COMPLEX for anything else than for the FBA? If not I can supply a fix by moving the list creation in the set(paramName, value) method of request.js

[tyscorp]

Type.COMPLEX is only used for FBA. I'd be happy if it was replaced with something good.

[florianbepunkt]

@tyscorp just submitted a PR #68 that fixes FBA outbound shipping. I haven't touched inbound shipping or inventory so can't say if they work

[gholevas]

Did PR #68 really fix this outbound shipping problem for you with the same format for LineItems you provided in the example above? I'm still getting "Error: The request signature we calculated does not match the signature you provided."

It's strange because your PR actually did fix the problem for GetFulfillmentPreview but not for CreateFulfillmentOrder

[florianbepunkt]

@gholevas that's strange indeed. I did some initial tests and everything worked but we haven't used this in production yet (but we will in about two months). But looking at the PR I basically just fixed the request so this should work for CreateFulfillmentOrder.

On the other hand there were several commits regarding fba after I created the PR which was never merged. So maybe my PR is no longer compatible.

[gholevas]

Thanks for getting back to me. The problem was actually the DisplayableOrderComment parameter was not being properly escaped and thus the signature was generated incorrectly

[eli8levit]

@gholevas @florianbepunkt Can you help please, I have exactly the same problem. I need to implement Creating Fulfillment today, but nothing works out, I get "The request signature we calculated does not match the signature you provided."
Thank you!

[florianbepunkt]

@JediYozh Mh… sounds like you have a problem with authentication and not with the fulfillment. Have you tried Amazin MWS scratchpad… does it work? If so, what I would do to debug is use the scratchpad and compare the request with the request from mws-api… you might dig into the request module to log the actual request that is made. Or you may try to use as few parameters when creating a fulfillment order as possible (stick to mws api guide to see which parameters are necessary), then add your additional params one by one until you find what's causing the invalid checksum.

here's my code…  keep in mind that I forked the repo and implemented a PR, so not sure if this would work exactly the same with this repo.

import moment from 'moment';
import MWSClient from 'mws-api';


class Fulfillment {

  /**
   * [constructor description]
   * @method constructor
   * @return {[type]}    [description]
   */
  constructor() {
    this.mws = new MWSClient({
      host: process.env.AMAZON_HOST,
      accessKeyId: process.env.AMAZON_ACCESS_KEY,
      secretAccessKey: process.env.AMAZON_SECRET,
      merchantId: process.env.AMAZON_MERCHANT_ID,
      meta: {
        retry: true, // retry requests when throttled
        next: true, // auto-paginate
        limit: Infinity // only get this number of items (NOT the same as MaxRequestsPerPage)
      }
    });
  }

  /**
   * [createFulfillmentOrder description]
   * @method createFulfillmentOrder
   * @param  {[type]}               order [description]
   * @return {[type]}                     [description]
   */
  createFulfillmentOrder(order) {
    return this.mws.FulfillmentOutboundShipment.CreateFulfillmentOrder({
      SellerFulfillmentOrderId: order.id,
      ShippingSpeedCategory: 'Standard',
      DisplayableOrderId: order.id,
      DisplayableOrderDateTime: moment(order.invoiceDate).format(),
      DisplayableOrderComment: 'Vielen Dank für Ihre Bestellung.',
      FulfillmentPolicy: 'FillOrKill',
      FulfillmentAction: 'Hold',
      DestName: order.shippingAddress.name,
      DestAddressLine1: order.shippingAddress.company,
      DestAddressLine2: order.shippingAddress.address1,
      DestAddressLine3: order.shippingAddress.address2,
      DestCity: order.shippingAddress.city,
      DestPostalCode: order.shippingAddress.postalcode,
      DestCountryCode: order.shippingAddress.countryCode,
      LineItems: this.formatLineItems(order.orderItems)
    });
  }

  /**
   * [formatLineItems description]
   * @method formatLineItems
   * @param  {[type]}        orderItems [description]
   * @return {[type]}                   [description]
   */
  formatLineItems(orderItems) {
    let lineItems = [];

    for (let orderItem of orderItems) {
      lineItems.push({
        DisplayableComment: orderItem.product.title,
        GiftMessage: '',
        Quantity: orderItem.quantity,
        SellerFulfillmentOrderItemId: orderItem.product.ean,
        SellerSKU: orderItem.product.amazonSellerSKU,
      })
    }

    return lineItems;
  }
}

export default new Fulfillment();

[eli8levit]

@florianbepunkt it's not authentication problem because other requests such as "ListOrders" , "ListOrderItems", "GetOrder" and others work great! This trouble happens only in this request. I think the reason is LineItems. @gholevas said it was "DisplayableOrderComment" but what did he do?
Florian, where do I get MWSAuthToken? Because in this module it's not required...
thank you very much for help!!

[florianbepunkt]

I agreee. If the other requests work, than the problem is the FBA part.

Can you show me your code (strip out the credentials)? Regarding the token: Have you tried to leave it just empty?

[eli8levit]

`const MWSClient = require('mws-api');
const mws = new MWSClient({
MarketplaceId: '',
accessKeyId: '',
secretAccessKey: '',
merchantId: '',
meta: {
retry: true, // retry requests when throttled
next: true, // auto-paginate
limit: Infinity
}
})

amazonUK.FulfillmentOutboundShipment.CreateFulfillmentOrder({
SellerFulfillmentOrderId : '1112dsd1314sdd1516',
DisplayableOrderId : '1112dsd1314sdd1516',
ShippingSpeedCategory: 'Standard',
DisplayableOrderDateTime : '2017-09-12T08:03:17.255Z',
DestName : "2A Stanlake Rd Shepherd's Bush, London W12 7HP",
DestCountryCode : 'UK',
DisplayableOrderComment: 'Your Package',
LineItems : [{
Quantity : 1,
SellerFulfillmentOrderItemId: 'sdsd5d5sd5',
SellerSKU : '2sdd2d2'
}]
}).then(({result}) => {
var xml = result;
parseString(xml, (err, result) => {
if (err) {
console.log(err);
}
console.log(result);
})
})
.catch((err) => {
console.log(err);
});

[eli8levit]

@florianbepunkt sorry for terrible view, it doesn't let me to insert the code in correct way...