Skip to content

Add Traditional Chinese language entry #10386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hezhen0816 wants to merge 2 commits into
base: master
Choose a base branch
from
+4 −0
Open

Add Traditional Chinese language entry #10386

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
067d79c
Add Traditional Chinese language entry
Apr 26, 2026
be8e692
Add Traditional Chinese display name
Apr 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/slic3r/GUI/GUI_App.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -780,6 +780,7 @@ bool has_filaments(const std::vector<string>& model_filaments);
static std::vector<wxLanguage> s_supported_languages = {
wxLANGUAGE_ENGLISH,
wxLANGUAGE_CHINESE_SIMPLIFIED,
wxLANGUAGE_CHINESE_TRADITIONAL,
wxLANGUAGE_GERMAN,
Comment on lines 782 to 784
Copy link

Copilot AI Apr 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding Traditional Chinese here will allow the zh_TW catalog to pass the supported-language filter, but the Preferences language combobox currently overrides several languages (including Simplified Chinese) to show a native self-name. Without adding a similar override for Traditional Chinese, the new entry will likely display as the wxWidgets default description (e.g., "Chinese (Traditional)") and be inconsistent with the existing Chinese entry. Consider adding a Traditional Chinese display-name override in PreferencesDialog::create_item_language_combobox when comparing against wxLocale::GetLanguageInfo(wxLANGUAGE_CHINESE_TRADITIONAL).

Copilot uses AI. Check for mistakes.
wxLANGUAGE_FRENCH,
wxLANGUAGE_SPANISH,
Expand Down
3 changes: 3 additions & 0 deletions src/slic3r/GUI/Preferences.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,6 +144,9 @@ wxBoxSizer *PreferencesDialog::create_item_language_combobox(
if (vlist[i] == wxLocale::GetLanguageInfo(wxLANGUAGE_CHINESE_SIMPLIFIED)) {
language_name = wxString::FromUTF8("\xe4\xb8\xad\xe6\x96\x87\x28\xe7\xae\x80\xe4\xbd\x93\x29");
}
else if (vlist[i] == wxLocale::GetLanguageInfo(wxLANGUAGE_CHINESE_TRADITIONAL)) {
language_name = wxString::FromUTF8("\xe4\xb8\xad\xe6\x96\x87\x28\xe7\xb9\x81\xe9\xab\x94\x29");
}
else if (vlist[i] == wxLocale::GetLanguageInfo(wxLANGUAGE_SPANISH)) {
language_name = wxString::FromUTF8("\x45\x73\x70\x61\xc3\xb1\x6f\x6c");
}
Expand Down
Loading