Add Traditional Chinese language entry#10386
Add Traditional Chinese language entry#10386hezhen0816 wants to merge 2 commits intobambulab:masterfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Adds Traditional Chinese to the app’s supported language whitelist so the existing zh_TW translation catalog can be surfaced in the language selector and accepted as a configured/system language.
Changes:
- Add
wxLANGUAGE_CHINESE_TRADITIONALtos_supported_languages.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| wxLANGUAGE_CHINESE_SIMPLIFIED, | ||
| wxLANGUAGE_CHINESE_TRADITIONAL, | ||
| wxLANGUAGE_GERMAN, |
There was a problem hiding this comment.
Adding Traditional Chinese here will allow the zh_TW catalog to pass the supported-language filter, but the Preferences language combobox currently overrides several languages (including Simplified Chinese) to show a native self-name. Without adding a similar override for Traditional Chinese, the new entry will likely display as the wxWidgets default description (e.g., "Chinese (Traditional)") and be inconsistent with the existing Chinese entry. Consider adding a Traditional Chinese display-name override in PreferencesDialog::create_item_language_combobox when comparing against wxLocale::GetLanguageInfo(wxLANGUAGE_CHINESE_TRADITIONAL).
This adds Traditional Chinese to the supported language list so the existing zh_TW translation can appear in the language selector.
The zh_TW translation files were added in #9705, and this follows up on the maintainer note that the language entry would be added later.
Testing: