Skip to content

Add Traditional Chinese language entry#10386

Open
hezhen0816 wants to merge 2 commits intobambulab:masterfrom
hezhen0816:add-zh-tw-language-entry
Open

Add Traditional Chinese language entry#10386
hezhen0816 wants to merge 2 commits intobambulab:masterfrom
hezhen0816:add-zh-tw-language-entry

Conversation

@hezhen0816
Copy link
Copy Markdown
Contributor

This adds Traditional Chinese to the supported language list so the existing zh_TW translation can appear in the language selector.

The zh_TW translation files were added in #9705, and this follows up on the maintainer note that the language entry would be added later.

Testing:

  • Not run locally; macOS build is currently blocked by local dependency build issues unrelated to this one-line language entry change.

Copilot AI review requested due to automatic review settings April 26, 2026 08:13
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds Traditional Chinese to the app’s supported language whitelist so the existing zh_TW translation catalog can be surfaced in the language selector and accepted as a configured/system language.

Changes:

  • Add wxLANGUAGE_CHINESE_TRADITIONAL to s_supported_languages.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines 782 to 784
wxLANGUAGE_CHINESE_SIMPLIFIED,
wxLANGUAGE_CHINESE_TRADITIONAL,
wxLANGUAGE_GERMAN,
Copy link

Copilot AI Apr 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding Traditional Chinese here will allow the zh_TW catalog to pass the supported-language filter, but the Preferences language combobox currently overrides several languages (including Simplified Chinese) to show a native self-name. Without adding a similar override for Traditional Chinese, the new entry will likely display as the wxWidgets default description (e.g., "Chinese (Traditional)") and be inconsistent with the existing Chinese entry. Consider adding a Traditional Chinese display-name override in PreferencesDialog::create_item_language_combobox when comparing against wxLocale::GetLanguageInfo(wxLANGUAGE_CHINESE_TRADITIONAL).

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants