Skip to content

Track ACP registry install receipts#682

Open
Finesssee wants to merge 42 commits into
athasdev:masterfrom
Finesssee:codex/acp-registry-lifecycle
Open

Track ACP registry install receipts#682
Finesssee wants to merge 42 commits into
athasdev:masterfrom
Finesssee:codex/acp-registry-lifecycle

Conversation

@Finesssee
Copy link
Copy Markdown
Contributor

@Finesssee Finesssee commented May 9, 2026

Summary

  • Consolidate the ACP runtime/catalog stack into one resolved PR
  • Preserve Athas' legacy marketplace agents while adding registry-backed ACP providers and custom/settings-backed agent servers
  • Harden managed install receipts, wrapper paths, registry command aliases, package/runtime metadata, and update detection
  • Keep unsupported registry entries out of the marketplace while preserving install/start metadata for supported providers
  • Improve ACP selector UX with scrollable/taller provider selection, colored provider icons, and reliable tab/chat routing
  • Surface provider setup/auth/runtime failures with clearer frontend error blocks
  • Preserve the useful ACP client/harness coverage from the older overlapping ACP PRs without reintroducing their stale runtime implementations

Validation

  • bun typecheck
  • bunx vp test run src/features/ai/tests/acp-provider-errors.test.ts src/features/ai/tests/error-block-parsing.test.ts src/features/ai/tests/acp-cancellation.test.ts src/features/ai/tests/acp-permission.test.ts src/features/ai/tests/acp-usage.test.ts
  • cargo test -p athas-ai acp
  • cargo test -p athas ai::acp
  • git diff --check
  • Local Athas Dev run from this branch via bun dev, verified with Computer Use that the ACP selector shows the expanded catalog with colored icons and tail providers are reachable by search

PR Consolidation

This PR supersedes the older overlapping ACP PRs: #673, #678, #681, #683, #684, and #685. Their useful non-conflicting pieces were folded into this branch, while this branch keeps the newer ACP runtime/catalog implementation for the files that conflicted.

Finesssee added 30 commits May 8, 2026 21:10
Merge registry agents ahead of the legacy Athas marketplace catalog while
preserving legacy-only entries as fallback options.

Add agentServers settings support for custom agents and registry env/default
overrides, and apply configured defaults through ACP session controls when
available.

Cover catalog precedence, custom agent mapping, env/default overrides,
malformed local entries, and settings import/normalization with focused tests.
Finesssee added 2 commits May 10, 2026 20:02
…ex/acp-pr673-compat-check

# Conflicts:
#	crates/ai/src/acp/bridge_init.rs
#	src-tauri/src/commands/ai/acp.rs
Finesssee added 2 commits May 10, 2026 20:06
…o codex/acp-pr683-compat-check

# Conflicts:
#	src/features/ai/components/selectors/agent-selector.tsx
@Finesssee
Copy link
Copy Markdown
Contributor Author

Consolidated the ACP stack here so reviewers only need to track one resolved branch. This PR now supersedes #673, #678, #681, #683, #684, and #685; useful pieces from those branches were folded in, and the newer ACP runtime/catalog implementation was kept for conflicting files.

Finesssee added 2 commits May 10, 2026 20:12
…y-lifecycle

# Conflicts:
#	src/features/collaboration/components/collaboration-sidebar.tsx
#	src/features/command-palette/components/command-palette.tsx
#	src/features/debugger/components/debug-breakpoint-indicators.tsx
#	src/features/editor/components/diff/inline-diff.tsx
#	src/features/editor/components/editor.tsx
#	src/features/editor/components/gutter/fold-indicators.tsx
#	src/features/editor/components/gutter/git-indicators.tsx
#	src/features/editor/components/gutter/gutter.tsx
#	src/features/editor/hooks/use-fold-transform.ts
#	src/features/editor/hooks/use-tokenizer.ts
#	src/features/editor/stores/editor-app-store.ts
#	src/features/layout/components/footer/footer.tsx
#	src/features/layout/components/sidebar/main-sidebar.tsx
#	src/features/layout/components/sidebar/sidebar-pane-selector.tsx
@Finesssee
Copy link
Copy Markdown
Contributor Author

Final consolidation pass done. #682 is now merged with current master using a normal merge commit, the diff is scoped to ACP/settings files, and GitHub reports it as mergeable. Validation rerun after the master merge: bun typecheck, focused ACP Vitest tests, cargo test -p athas-ai acp, cargo test -p athas ai::acp, and git diff --check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant