Align ACP agent catalog behavior#678
Closed
Finesssee wants to merge 6 commits into
Closed
Conversation
Merge registry agents ahead of the legacy Athas marketplace catalog while preserving legacy-only entries as fallback options. Add agentServers settings support for custom agents and registry env/default overrides, and apply configured defaults through ACP session controls when available. Cover catalog precedence, custom agent mapping, env/default overrides, malformed local entries, and settings import/normalization with focused tests.
e55b3d4 to
6c281b1
Compare
This was referenced May 9, 2026
Contributor
Author
Contributor
Author
|
Closing as superseded by #682 to keep the ACP work in one resolved runtime/catalog branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
agentServerssettings support for custom agents and registry env/default overrides without adding a new UI surface.npx, anduvxagents installable through Athas' managed tool installer so registry-only agents can be installed from the existing Agents marketplace.Validation
cargo test -p athas-ai acpcargo test -p athas ai::acpcargo test -p athas-tooling resolves_cargo check -p athas-aicargo check -p athas-toolingbun typecheckcargo +nightly fmt --all --checkgit diff --checkAthas Dev.appbundle, searched the Agents marketplace for registry-onlyAmp, clickedInstall, and confirmed the row changed toUninstall.docs/goals/is absent from the PR diff.npm view, and 2 Python packages resolve throughpip index versions.cargo test -p athas acpcargo test -p athas acp_registrybun devand verified the running debug binary was/Users/sw/Code/athas/target/debug/athas.Athas Dev, opened a fresh agent tab, selected a registry-backed provider (GLM Agent), senthi, and confirmed Athas launched the provider path successfully. The provider returned its own missingZ_AI_API_KEYsetup error, which verifies the UI/registry/install/launch path reached the actual ACP provider rather than failing in Athas.