chore(wealth): capture divergent local state — 8 commits ahead of origin - #67
Merged
Merged
Conversation
…r derived + F4 gate when reflection absent
BUG 1 (F1): CoercedDictListStrict type wraps dict→[dict] for current_kpis +
decision_makers + beneficiaries + cost_bearers + actors + trust_events +
exported_costs. Prevents silent input dropping when callers pass flat dicts.
BUG 2 (F2): shadow=True now suppresses vault receipt emission in server.py.
Gate reads arguments.shadow at _emit_receipt call site (not result envelope).
wrap_result respects explicit shadow kwarg, auto-shadow still fires from
violations/holds when shadow not explicitly provided.
BUG 3 (F3): kappa_r derived from evidence_quality enum instead of hardcoded
0.93. OBSERVED=0.88, MODERATE=0.70, WEAK=0.52, MISSING=0.35,
SPECULATED=0.42. Explicit kappa_r override still supported.
BUG 4 (F4): metric_purpose_audit now routes through _wrap_entropy instead of
direct wrap_result call. evidence_quality:MISSING + gate:PASS + no reflection
prose → CAUTION gate with explanatory warning. metric_purpose_audit (always
MISSING by design) passes gate via reflection prose.
Files: canonical.py (+27/-1), server.py (+25/-11), envelope.py (+17/-2),
tests/test_capital_entropy_bugfixes.py (new, 14 tests, 14/14 PASS)
Peer audit: OpenClaw DO NOT MERGE → architectural F2 fix → opencode redo
→ manual F2/F4 completion → 14/14 green.
DITEMPA BUKAN DIBERI.
…pe coercion + kappa_r + evidence gate
F1: CoercedDictListStrict in canonical.py coerces dict→list-of-dicts
for 7 fields (decision_makers,beneficiaries,cost_bearers,current_kpis,
actors,trust_events,exported_costs). Prevents silent input dropping.
F2: shadow=True now suppresses vault receipt writes in server.py at the
_emit_receipt layer. Explicit param only (arguments.get('shadow')),
not envelope auto-shadow (violations/holds → shadow is for UI).
F3: kappa_r derived from evidence_quality, not hardcoded 0.93.
OBSERVED=0.88 MODERATE=0.70 WEAK=0.52 MISSING=0.35 SPECULATED=0.42.
F4: _w0_evidence_gate checks evidence_quality=MISSING + gate=PASS +
no reflection → downgrade CAUTION (scoped to avoid false positives
on metric_purpose_audit which always has reflection prose).
Root cause of Arif's DOSM 8-field INSUFFICIENT_EVIDENCE: type mismatch
list[str] passed to CoercedDictList params → W0 coverage 0.0.
CoercedDictListStrict + schema-correct args → PARTIAL at coverage > 0.15.
Files: canonical.py (+shadow threading, +CoercedDictListStrict)
server.py (+shadow gate, +evidence_quality F4 check)
envelope.py (+kappa_r derivation, +shadow kwarg passthrough)
Tests: test_capital_entropy_bugfixes.py (146 lines, 14 tests, all pass)
Co-authored-by: kimi-code/FI-008
Verified-by: OPENCLAW (independent audit)
… #683) Pattern replication across federation organs. DITEMPA BUKAN DIBERI
- README.md — +88 canonical 6-plane framing Evidence: F2 OBS — git diff --stat HEAD~..HEAD Session: kimi-code/FI-008 fedsession-20260811T011500Z
UNFINISHED_JOB_RECOVERY v1 — recover inherited untracked file. File: - trading/cron/refresh_market_digests.py (NEW: refreshes gold/oil/gas/klci/usdmyr digests at arif-fazil.com/data/markets/) Refs: RECOVERY_REPORT.md, PRIORITY-WEALTH-COMMIT, PATH5 trading cron repair. F1 AMANAH: reversible. Lane B autonomous.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughThe PR adds a scheduled market digest generator for five instruments and updates project task and federation documentation. The generator calculates indicators, writes bilingual JSON files, copies public outputs, and records refresh results. ChangesMarket Digest Refresh
Project Documentation and Task Specification
Estimated code review effort: 4 (Complex) | ~45 minutes Sequence Diagram(s)sequenceDiagram
participant RefreshScript
participant YahooFinance
participant SourceDirectory
participant PublicDirectory
participant RefreshLog
RefreshScript->>YahooFinance: fetch history for each instrument
YahooFinance-->>RefreshScript: return market data or fetch error
RefreshScript->>SourceDirectory: write bilingual JSON digest
RefreshScript->>PublicDirectory: copy generated digest
RefreshScript->>RefreshLog: record per-market and aggregate results
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ariffazil
pushed a commit
that referenced
this pull request
Aug 13, 2026
…EDERATION.md symlink Terminology migration across monolith.py, collapse_signature/patterns.py, kinabalu domain doc. docs/FEDERATION.md symlink now points to /root/AAA/docs/FEDERATION_CONTRACT.md (verified exists). Triage capture of divergent local state (pattern: #67).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Local WEALTH has 8 commits ahead of origin/main (divergent state from earlier session).
Origin/main has 2 commits not in local.
Cannot fast-forward; this PR captures the local divergent state on a topic branch.
Local-ahead commits (8)
Origin-ahead (2, in main, not in this PR)
Risk
§5 admin-auto-merge gate: divergence is historical (8 commits stable on local),
no functional runtime surface changed in this branch.
F1 AMANAH: original main retained locally; this PR captures the divergent state.
F2 evidence: 8 commits, all with Kimi authorship 2026-08-11.
Refs: hermes-arif-20260812-federation-audit
Summary by CodeRabbit
New Features
Documentation