[fix][broker] Fix PersistentMessageExpiryMonitor findEntryComplete() method may lose mark-delete properties in race condition

[oneby-wang]

Motivation

This is a follow-up to #25165 and the same class of mark-delete properties race condition, covering PersistentMessageExpiryMonitor.findEntryComplete().

PersistentMessageExpiryMonitor.findEntryComplete() may lose mark-delete properties in a race condition.

When the expiry monitor advances a cursor while another markDelete() call with properties is in progress, passing the cursor current properties can capture stale properties and later overwrite the user-provided mark-delete properties.

Modifications

1. Add testExpireMessagesNeverLoseMarkDeleteProperties() test to reproduce the issue.
2. Pass null to asyncMarkDelete() method properties param in PersistentMessageExpiryMonitor.findEntryComplete(), so the cursor uses the latest properties when the mark-delete is applied.
3. Run test to verify the code change.

Verifying this change

• Make sure that the change passes the CI checks.

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

• Dependencies (add or upgrade a dependency)
• The public API
• The schema
• The default values of configurations
• The threading model
• The binary protocol
• The REST endpoints
• The admin CLI options
• The metrics
• Anything that affects deployment

Documentation

• doc
• doc-required
• doc-not-needed
• doc-complete

Matching PR in forked repository

PR in forked repository: oneby-wang#33