[fix][broker] Fix compaction cursor reset may lose mark-delete properties#25862
Merged
lhotari merged 2 commits intoMay 25, 2026
Merged
Conversation
lhotari
approved these changes
May 25, 2026
Contributor
Author
|
/pulsarbot rerun-failure-checks |
priyanshu-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jun 9, 2026
…ties (apache#25862) (cherry picked from commit 9b15504) (cherry picked from commit a7cb7e8)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This is a follow-up to #25165, #25796, and #25803 for the same class of mark-delete properties race condition, covering
ManagedCursorImpl.internalResetCursor()for the compaction cursor.ManagedCursorImpl.internalResetCursor()may lose compaction cursor mark-delete properties in a race condition.When compaction cursor reset persists a mark-delete position while another
asyncMarkDelete()call with properties is in progress, passing the cursor current properties can capture stale properties and later overwrite the compaction mark-delete properties, such asCompactedTopicLedger.Modifications
testCompactionCursorResetNeverLoseMarkDeleteProperties()test to reproduce the issue.nulltointernalAsyncMarkDelete()for compaction cursor reset, so the cursor uses the latest properties when the mark-delete is applied.Verifying this change
./gradlew :managed-ledger:test --tests org.apache.bookkeeper.mledger.impl.ManagedCursorTest.testCompactionCursorResetNeverLoseMarkDeletePropertiesDoes this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-complete