Skip to content

[cleanup] Catch TimeoutException when logging about time outs#20349

Merged
michaeljmarshall merged 1 commit into
apache:masterfrom
michaeljmarshall:fix-timeout-error
May 18, 2023
Merged

[cleanup] Catch TimeoutException when logging about time outs#20349
michaeljmarshall merged 1 commit into
apache:masterfrom
michaeljmarshall:fix-timeout-error

Conversation

@michaeljmarshall

Copy link
Copy Markdown
Member

Relates to: #20299

Motivation

We have several catch blocks that are dedicated to providing meaningful logs about timeouts. As such, we should catch the TimeoutException, not the InterruptedException, in order to ensure accurate logs.

Modifications

  • Replace InterruptedException with TimeoutException

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Documentation

  • doc-not-needed

@michaeljmarshall michaeljmarshall added type/cleanup Code or doc cleanups e.g. remove the outdated documentation or remove the code no longer in use doc-not-needed Your PR changes do not impact docs ready-to-test labels May 18, 2023
@michaeljmarshall michaeljmarshall added this to the 3.1.0 milestone May 18, 2023
@michaeljmarshall michaeljmarshall self-assigned this May 18, 2023
@codecov-commenter

codecov-commenter commented May 18, 2023

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.92%. Comparing base (e4f1f09) to head (a9e902e).
⚠️ Report is 2520 commits behind head on master.

Files with missing lines Patch % Lines
...sar/broker/authorization/AuthorizationService.java 0.00% 3 Missing ⚠️
...java/org/apache/pulsar/broker/rest/TopicsBase.java 0.00% 1 Missing ⚠️
...a/org/apache/pulsar/websocket/ConsumerHandler.java 0.00% 1 Missing ⚠️
...a/org/apache/pulsar/websocket/ProducerHandler.java 0.00% 1 Missing ⚠️
...ava/org/apache/pulsar/websocket/ReaderHandler.java 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             master   #20349       +/-   ##
=============================================
+ Coverage     36.80%   72.92%   +36.12%     
- Complexity    12046    31861    +19815     
=============================================
  Files          1687     1864      +177     
  Lines        128755   138313     +9558     
  Branches      14002    15172     +1170     
=============================================
+ Hits          47389   100871    +53482     
+ Misses        75106    29438    -45668     
- Partials       6260     8004     +1744     
Flag Coverage Δ
inttests 24.15% <0.00%> (-0.04%) ⬇️
systests 25.03% <0.00%> (+0.15%) ⬆️
unittests 72.21% <0.00%> (+40.21%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...java/org/apache/pulsar/broker/rest/TopicsBase.java 58.45% <0.00%> (+58.45%) ⬆️
...a/org/apache/pulsar/websocket/ConsumerHandler.java 62.50% <0.00%> (+37.09%) ⬆️
...a/org/apache/pulsar/websocket/ProducerHandler.java 63.21% <0.00%> (+32.18%) ⬆️
...ava/org/apache/pulsar/websocket/ReaderHandler.java 47.05% <0.00%> (+47.05%) ⬆️
...sar/broker/authorization/AuthorizationService.java 57.20% <0.00%> (+44.80%) ⬆️

... and 1427 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@michaeljmarshall michaeljmarshall merged commit 65f6112 into apache:master May 18, 2023
@michaeljmarshall michaeljmarshall deleted the fix-timeout-error branch May 18, 2023 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc-not-needed Your PR changes do not impact docs ready-to-test type/cleanup Code or doc cleanups e.g. remove the outdated documentation or remove the code no longer in use

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants