[improve][ws] Use allowTopicOperationAsync for authz checks#20299
Merged
michaeljmarshall merged 1 commit intoMay 18, 2023
Conversation
15 tasks
Technoboy-
reviewed
May 11, 2023
Technoboy-
reviewed
May 11, 2023
Member
|
@michaeljmarshall build must be retried in 3 days until completion. After that, it's necessary to rebuild all |
Codecov Report
@@ Coverage Diff @@
## master #20299 +/- ##
=============================================
+ Coverage 34.48% 72.22% +37.74%
+ Complexity 12528 4327 -8201
=============================================
Files 1614 1869 +255
Lines 126177 141439 +15262
Branches 13772 15999 +2227
=============================================
+ Hits 43508 102157 +58649
+ Misses 77051 31094 -45957
- Partials 5618 8188 +2570
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Member
Author
|
Thanks @lhotari. I forgot to follow up on this PR. |
Member
Author
|
/pulsarbot rerun-failure-checks |
1 similar comment
Member
Author
|
/pulsarbot rerun-failure-checks |
Member
Author
|
The pulsar io phase failed on the upload step: |
Member
Author
|
/pulsarbot rerun-failure-checks |
1 task
michaeljmarshall
added a commit
that referenced
this pull request
May 18, 2023
Relates to: #20299 ### Motivation We have several catch blocks that are dedicated to providing meaningful logs about timeouts. As such, we should catch the `TimeoutException`, not the `InterruptedException`, in order to ensure accurate logs. ### Modifications * Replace `InterruptedException` with `TimeoutException` ### Verifying this change This change is a trivial rework / code cleanup without any test coverage. ### Documentation - [x] `doc-not-needed`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to: #20142
Motivation
In #20142 we changed the
Consumerand theProducerlogic to call the correctAuthorizationServicemethod.Our goal is to deprecate the
AuthorizationServicemethods forcanProduceandcanConsume, so this change helps us move in the right direction.This PR follows the same logic and updates the WebSocket proxy to remove all calls to the
can*methods in theAuthorizationServiceModifications
ProducerHandler,ConsumerHandler, andReaderHanderin the WebSocket Proxy to call theAuthorizationService#allowTopicOperationAsyncmethod.Verifying this change
This change is trivial.
Documentation
doc-not-neededMatching PR in forked repository
PR in forked repository: Skipping PR as I ran tests locally.