[MNG-5913] Allow defining aliases for existing server configurations in settings.xml by slawekjaranowski · Pull Request #2333 · apache/maven

slawekjaranowski · 2025-05-13T19:31:17Z

Add the next tag ids to the server in settings.xml

Additional server will be created in memory by SettingsBuilder, so the generated configuration should be transparent to other as Settings#getServers() will return complete list.

https://issues.apache.org/jira/browse/MNG-5913

cstamas · 2025-05-13T19:54:13Z

This needs to be made sure will not break Maven 3, as same settings is shared by both currently.

slawekjaranowski · 2025-05-13T20:20:01Z

This needs to be made sure will not break Maven 3, as same settings is shared by both currently.

unit test, looks ok for me.

I tested with: mvn help:effective-settings

slawekjaranowski · 2025-05-14T21:10:29Z

ok, who is willing to work on it with me?
If proposition will be generally accepted I will do similar in 3.9.x

I hope such feature will be valuable.

cstamas · 2025-05-14T21:13:11Z

Well, settings with current 3.9.9 are NOT read:

[WARNING] 
[WARNING] Some problems were encountered while building the effective settings
[WARNING] Unrecognised tag: 'aliases' (position: START_TAG seen ...</id>\n     <aliases>... @61:15)  @ /home/cstamas/.m2/settings.xml, line 61, column 15
[WARNING]

Or this is "ok"? Is settings loaded partially or discaded?

cstamas · 2025-05-14T21:14:38Z

I am willing to jump in as Njord does something similar, but my concern is that Maven 3.x is not "forgiving" while readint settings.xml AFAIK. And if we modify XML then things like ./mvnw will work ONLY (for user) if 3.9.10 used?

slawekjaranowski · 2025-05-14T21:17:54Z

Well, settings with current 3.9.9 are NOT read:

[WARNING] 
[WARNING] Some problems were encountered while building the effective settings
[WARNING] Unrecognised tag: 'aliases' (position: START_TAG seen ...</id>\n     <aliases>... @61:15)  @ /home/cstamas/.m2/settings.xml, line 61, column 15
[WARNING]

Or this is "ok"? Is settings loaded partially or discaded?

it is correct because 3.9.x does not have it yet

slawekjaranowski · 2025-05-14T21:21:01Z

I am willing to jump in as Njord does something similar, but my concern is that Maven 3.x is not "forgiving" while readint settings.xml AFAIK. And if we modify XML then things like ./mvnw will work ONLY (for user) if 3.9.10 used?

I hope we can have next version of settings schema for 3.9.x ... so if someone update own settings alos will use newer version of Maven

Pankraz76

already very nice.
please give last dedication, to reach infinitive higher-order function.

Pankraz76

polish

slawekjaranowski · 2025-05-15T18:33:08Z

@gnodet @Pankraz76 last suggestions applied

gnodet

Review: [MNG-5913] Allow defining aliases for existing server configurations

This is a well-implemented feature that addresses a real pain point — users who need the same credentials for multiple repository servers currently have to duplicate the entire <server> block.

What looks good

Dual-layer implementation: Changes in both the v4 API (impl/maven-impl) and the v3 compat layer (compat/maven-settings-builder) with separate test suites for each.
Alias expansion logic: Correct — each settings file's aliases are expanded within that file before merging. Cross-source ID collisions are handled by the existing merge logic (last-wins).
Validation coverage: Tests cover basic servers (no aliases), servers with aliases (verifying expansion), duplicate alias detection, alias-equals-server-ID detection, and empty alias validation.
Schema versioning: The forcedIOModelVersion bump to 1.3.0 and <version>1.3.0+</version> on the aliases field follow standard Modello practice for schema evolution.
Deep copy: Server.newBuilder(server, true) correctly deep-copies all fields (including configuration DOM elements) to aliased servers.
Project settings: Aliases are correctly warned about and stripped from project settings, consistent with how other unsupported features are handled.

Open coordination items

The backward compatibility discussion between @cstamas, @michael-o, and @slawekjaranowski about whether settings.xml files using <aliases> should work across Maven versions is the main open question. This is a policy/coordination decision, not a code issue — the implementation is technically sound.

This review was generated by an AI agent and may contain inaccuracies. Please verify all suggestions before applying.

Claude Code on behalf of Guillaume Nodet

Reviewed 3 PRs: apache#2333 (server aliases, clean), apache#10971 (test, LGTM), apache#11186 (namespace validation, needs rework). 18 reviews total. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

slawekjaranowski · 2026-07-11T20:25:55Z

The backward compatibility discussion between @cstamas, @michael-o, and @slawekjaranowski about whether settings.xml files using <aliases> should work across Maven versions is the main open question. This is a policy/coordination decision, not a code issue — the implementation is technically sound.

settings.xml is locally managed by users in own controlled environments.
If someone use new feature should be aware that only works with newer Maven version.

Should be not a compatibility problem.

So as technically change is ok, should not be block to merge.

gnodet

Re-review: Allow defining aliases for existing server configurations

Verdict: APPROVE ✅

No new commits since the previous review (2026-07-10). The updatedAt change was triggered by the author's comment (2026-07-11) responding to the backward compatibility discussion.

Author's response to backward compat concern

slawekjaranowski argues that settings.xml is locally managed by users, so adopting the <aliases> feature inherently requires a newer Maven version — this should not block the merge. This is a reasonable position for an opt-in feature in a user-managed file.

Code assessment (unchanged)

The implementation remains clean across all reviewed dimensions:

Alias expansion correct in both v4 (DefaultSettingsBuilder) and v3 compat layers
Validation covers: duplicate alias-vs-id, duplicate alias-vs-alias, alias-equals-own-id, empty alias values
Comprehensive test coverage with dedicated XML fixtures
Schema versioning (1.3.0+, forcedIOModelVersion=1.3.0) follows Modello conventions
!isProjectSettings guard and project-settings alias stripping are correct

The remaining backward compat discussion is a project governance decision among committers, not a code issue.

This review was generated by an AI agent and may contain inaccuracies. Please verify all suggestions before applying.

Claude Code on behalf of Guillaume Nodet

…in settings.xml Add the next tag ids to the server in settings.xml Additional server will be created in memory by SettingsBuilder, so the generated configuration should be transparent to other as Settings#getServers() will return complete list.

…ion in `settings.mdo`.

gnodet

Re-review: Server aliases — post-rebase

Verdict: APPROVE ✅

Pure rebase onto latest base branch — same 20 files, same 641+/15−, same 11 commits with identical messages. No code changes. Previous approval stands.

This review was generated by an AI agent and may contain inaccuracies. Please verify all suggestions before applying.

Claude Code on behalf of Guillaume Nodet

…in settings.xml * [MNG-5913] Allow defining aliases for existing server configurations in settings.xml Add the next tag aliases to the server in settings.xml Additional server will be created in memory by SettingsBuilder, so the generated configuration should be transparent to other as Settings#getServers() will return complete list. Based on commit 09b2dfc #2333

slawekjaranowski requested review from cstamas, gnodet and michael-o May 13, 2025 19:31

slawekjaranowski added the enhancement New feature or request label May 13, 2025

slawekjaranowski self-assigned this May 13, 2025

slawekjaranowski commented May 13, 2025

View reviewed changes

Comment thread api/maven-api-settings/src/main/mdo/settings.mdo Outdated

slawekjaranowski commented May 13, 2025

View reviewed changes

Comment thread api/maven-api-settings/src/main/mdo/settings.mdo

slawekjaranowski force-pushed the MNG-5913 branch from 7230d9e to 563d2e2 Compare May 13, 2025 20:18

Pankraz76 reviewed May 14, 2025

View reviewed changes

Comment thread ...ettings-builder/src/main/java/org/apache/maven/settings/building/DefaultSettingsBuilder.java Outdated

Pankraz76 approved these changes May 14, 2025

View reviewed changes

Comment thread impl/maven-impl/src/main/java/org/apache/maven/impl/DefaultSettingsBuilder.java Outdated

Pankraz76 reviewed May 14, 2025

View reviewed changes

Comment thread impl/maven-impl/src/main/java/org/apache/maven/impl/DefaultSettingsBuilder.java

Pankraz76 reviewed May 14, 2025

View reviewed changes

Comment thread ...lder/src/test/java/org/apache/maven/settings/building/DefaultSettingsBuilderFactoryTest.java Outdated

Pankraz76 mentioned this pull request May 14, 2025

[POC] rewrite-maven-plugin: Introduce OpenRewrite by Moderne #2322

Closed

slawekjaranowski force-pushed the MNG-5913 branch 2 times, most recently from a959fb0 to e0b3b6b Compare May 14, 2025 22:18

Pankraz76 reviewed May 15, 2025

View reviewed changes

Pankraz76 mentioned this pull request May 15, 2025

Modernize codebase with Java improvements #2277

Open

gnodet reviewed May 15, 2025

View reviewed changes

Comment thread impl/maven-impl/src/main/java/org/apache/maven/impl/DefaultSettingsBuilder.java Outdated

gnodet reviewed May 15, 2025

View reviewed changes

Comment thread ...ettings-builder/src/main/java/org/apache/maven/settings/building/DefaultSettingsBuilder.java Outdated

Pankraz76 mentioned this pull request May 15, 2025

ReplaceCollectToListWithToList openrewrite/rewrite-static-analysis#558

Closed

slawekjaranowski requested review from Pankraz76 and gnodet May 15, 2025 18:33

slawekjaranowski force-pushed the MNG-5913 branch from 2ef5b3c to 811aa80 Compare June 23, 2026 15:18

slawekjaranowski requested a review from gnodet June 23, 2026 15:22

gnodet reviewed Jul 10, 2026

View reviewed changes

slawekjaranowski requested a review from gnodet July 11, 2026 20:26

gnodet approved these changes Jul 11, 2026

View reviewed changes

gnodet added a commit to gnodet/maven that referenced this pull request Jul 11, 2026

chore: update PR review loop state — re-reviewed apache#2333

8fae96f

slawekjaranowski added 11 commits July 11, 2026 22:56

Apply review suggestion - 1

cf2a2e7

Apply review suggestion - 2

5abd64e

cleanup of introduced comments

214df5b

Refresh changes - rename ids to aliases

cbc98f1

Use modello 2.7.0

6797f67

Fix trailing whitespace

61e174a

Fix tests to check correct server aliases and update aliases descript…

9a84bff

…ion in `settings.mdo`.

Add validation for server aliases

c67cd09

Next review fixes - check empty value for server aliases

c3009f8

Add pluralExceptions in compat/maven-settings, simplify condition

44b6b2d

slawekjaranowski force-pushed the MNG-5913 branch from 811aa80 to 44b6b2d Compare July 11, 2026 20:57

gnodet approved these changes Jul 11, 2026

View reviewed changes

gnodet added a commit to gnodet/maven that referenced this pull request Jul 11, 2026

chore: update PR review loop state — re-reviewed apache#2333 (rebase)

8b738b9

slawekjaranowski merged commit 09b2dfc into apache:master Jul 12, 2026
41 of 42 checks passed

slawekjaranowski deleted the MNG-5913 branch July 12, 2026 13:17

github-actions Bot added this to the 4.1.0 milestone Jul 12, 2026

slawekjaranowski linked an issue Jul 12, 2026 that may be closed by this pull request

[MNG-5913] Allow to define aliases for existing server configurations in settings.xml #7757

Closed

This was referenced Jul 12, 2026

[MNG-5913] Allow defining aliases for existing server configurations in settings.xml #12473

Merged

[MNG-5913] Allow defining aliases for existing server configurations in settings.xml #12475

Merged

jira-importer mentioned this pull request Jun 4, 2025

[MNG-5913] Allow to define aliases for existing server configurations in settings.xml #7757

Closed

Uh oh!

Conversation

slawekjaranowski commented May 13, 2025

Uh oh!

Uh oh!

Uh oh!

cstamas commented May 13, 2025

Uh oh!

slawekjaranowski commented May 13, 2025

Uh oh!

slawekjaranowski commented May 14, 2025

Uh oh!

cstamas commented May 14, 2025

Uh oh!

cstamas commented May 14, 2025

Uh oh!

slawekjaranowski commented May 14, 2025

Uh oh!

Uh oh!

slawekjaranowski commented May 14, 2025

Uh oh!

Pankraz76 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Pankraz76 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

slawekjaranowski commented May 15, 2025

Uh oh!

gnodet left a comment

Choose a reason for hiding this comment

Review: [MNG-5913] Allow defining aliases for existing server configurations

What looks good

Open coordination items

Uh oh!

slawekjaranowski commented Jul 11, 2026

Uh oh!

gnodet left a comment

Choose a reason for hiding this comment

Re-review: Allow defining aliases for existing server configurations

Author's response to backward compat concern

Code assessment (unchanged)

Uh oh!

gnodet left a comment

Choose a reason for hiding this comment

Re-review: Server aliases — post-rebase

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants