[MNG-5913] Allow defining aliases for existing server configurations in settings.xml#12473
Merged
slawekjaranowski merged 1 commit intoJul 12, 2026
Merged
Conversation
…in settings.xml * [MNG-5913] Allow defining aliases for existing server configurations in settings.xml Add the next tag aliases to the server in settings.xml Additional server will be created in memory by SettingsBuilder, so the generated configuration should be transparent to other as Settings#getServers() will return complete list. (cherry picked from commit 09b2dfc)
gnodet
approved these changes
Jul 12, 2026
gnodet
left a comment
gnodet
left a comment
Contributor
There was a problem hiding this comment.
Review: Server aliases backport to 4.0.x
Verdict: APPROVE ✅
Clean cherry-pick of the merged PR #2333 (master → maven-4.0.x). Same 20 files, same 641+/15−, identical code.
The server alias feature was thoroughly reviewed across 3 review cycles on #2333:
- Alias expansion correct in both v4 and v3 compat layers
- Validation covers duplicate alias-vs-id, alias-vs-alias, self-referencing, empty values
- Comprehensive test coverage with dedicated XML fixtures
- Schema versioning follows Modello conventions
No code differences from the merged version. LGTM.
This review was generated by an AI agent and may contain inaccuracies. Please verify all suggestions before applying.
Claude Code on behalf of Guillaume Nodet
gnodet
added a commit
to gnodet/maven
that referenced
this pull request
Jul 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the next tag aliases to the server in settings.xml
Additional server will be created in memory by SettingsBuilder, so the generated configuration should be transparent to other as Settings#getServers() will return complete list.
(cherry picked from commit 09b2dfc) #2333
Following this checklist to help us incorporate your
contribution quickly and easily:
Note that commits might be squashed by a maintainer on merge.
This may not always be possible but is a best-practice.
mvn verifyto make sure basic checks pass.A more thorough check will be performed on your pull request automatically.
If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.