Skip to content

[MNG-8650] Fix MAVEN_ARGS backslash stripping on Windows #12349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gnodet wants to merge 1 commit into
base: maven-4.0.x
Choose a base branch
from
+6 −7
Open

[MNG-8650] Fix MAVEN_ARGS backslash stripping on Windows #12349

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions apache-maven/src/assembly/maven/bin/mvn
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -286,15 +286,14 @@ cmd="\"$JAVACMD\" \
\"-Dmaven.mainClass=$MAVEN_MAIN_CLASS\" \
\"-Dlibrary.jline.path=${MAVEN_HOME}/lib/jline-native\" \
\"-Dmaven.multiModuleProjectDirectory=$MAVEN_PROJECTBASEDIR\" \
$LAUNCHER_CLASS \
$MAVEN_ARGS"
$LAUNCHER_CLASS"

if [ -n "$MAVEN_DEBUG_SCRIPT" ]; then
echo "[DEBUG] Launching JVM with command:" >&2
printf '[DEBUG] %s' "$cmd" >&2; printf ' "%s"' "$@" >&2; echo >&2
printf '[DEBUG] %s' "$cmd" >&2; printf ' %s' "$MAVEN_ARGS" >&2; printf ' "%s"' "$@" >&2; echo >&2
fi

# User arguments ("$@") are passed directly to preserve literal values
# like ${...} Maven property placeholders without shell expansion.
# Only the base command uses eval for MAVEN_OPTS word splitting.
eval exec "$cmd" '"$@"'
# User arguments ("$@") and MAVEN_ARGS are passed outside the eval'd string
# to preserve literal values (backslashes, ${...} placeholders) without
# shell re-parsing. Only the base command uses eval for MAVEN_OPTS word splitting.
eval exec "$cmd" '$MAVEN_ARGS' '"$@"'
Loading