Skip to content

fix: remove dead code catch block for ArtifactNotFoundException #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
prathamesh04 wants to merge 1 commit into from
+0 −5
Closed

fix: remove dead code catch block for ArtifactNotFoundException #113

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions src/main/java/org/apache/maven/shared/io/location/ArtifactLocatorStrategy.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,8 @@
import java.util.List;

import org.apache.maven.artifact.Artifact;
import org.apache.maven.artifact.factory.ArtifactFactory;

Check warning on line 24 in src/main/java/org/apache/maven/shared/io/location/ArtifactLocatorStrategy.java

View workflow job for this annotation

GitHub Actions / Verify / ubuntu-latest jdk-17-zulu 3.10.0-rc-1 

org.apache.maven.artifact.factory.ArtifactFactory in org.apache.maven.artifact.factory has been deprecated
import org.apache.maven.artifact.repository.ArtifactRepository;
import org.apache.maven.artifact.resolver.ArtifactNotFoundException;
import org.apache.maven.artifact.resolver.ArtifactResolutionException;
import org.apache.maven.artifact.resolver.ArtifactResolver;
import org.apache.maven.shared.io.logging.MessageHolder;
Expand All @@ -32,7 +31,7 @@
* The locator strategy.
*/
public class ArtifactLocatorStrategy implements LocatorStrategy {
private final ArtifactFactory factory;

Check warning on line 34 in src/main/java/org/apache/maven/shared/io/location/ArtifactLocatorStrategy.java

View workflow job for this annotation

GitHub Actions / Verify / ubuntu-latest jdk-17-zulu 3.10.0-rc-1 

org.apache.maven.artifact.factory.ArtifactFactory in org.apache.maven.artifact.factory has been deprecated

private final ArtifactResolver resolver;

Expand All @@ -51,7 +50,7 @@
* @param remoteRepositories {@link ArtifactRepository}
*/
public ArtifactLocatorStrategy(
ArtifactFactory factory,

Check warning on line 53 in src/main/java/org/apache/maven/shared/io/location/ArtifactLocatorStrategy.java

View workflow job for this annotation

GitHub Actions / Verify / ubuntu-latest jdk-17-zulu 3.10.0-rc-1 

org.apache.maven.artifact.factory.ArtifactFactory in org.apache.maven.artifact.factory has been deprecated
ArtifactResolver resolver,
ArtifactRepository localRepository,
List<ArtifactRepository> remoteRepositories) {
Expand All @@ -69,7 +68,7 @@
* @param defaultArtifactType default artifact type.
*/
public ArtifactLocatorStrategy(
ArtifactFactory factory,

Check warning on line 71 in src/main/java/org/apache/maven/shared/io/location/ArtifactLocatorStrategy.java

View workflow job for this annotation

GitHub Actions / Verify / ubuntu-latest jdk-17-zulu 3.10.0-rc-1 

org.apache.maven.artifact.factory.ArtifactFactory in org.apache.maven.artifact.factory has been deprecated
ArtifactResolver resolver,
ArtifactRepository localRepository,
List<ArtifactRepository> remoteRepositories,
Expand All @@ -90,7 +89,7 @@
* @param defaultClassifier default classifier.
*/
public ArtifactLocatorStrategy(
ArtifactFactory factory,

Check warning on line 92 in src/main/java/org/apache/maven/shared/io/location/ArtifactLocatorStrategy.java

View workflow job for this annotation

GitHub Actions / Verify / ubuntu-latest jdk-17-zulu 3.10.0-rc-1 

org.apache.maven.artifact.factory.ArtifactFactory in org.apache.maven.artifact.factory has been deprecated
ArtifactResolver resolver,
ArtifactRepository localRepository,
List<ArtifactRepository> remoteRepositories,
Expand Down Expand Up @@ -150,7 +149,7 @@
}

try {
resolver.resolve(artifact, remoteRepositories, localRepository);

Check failure on line 152 in src/main/java/org/apache/maven/shared/io/location/ArtifactLocatorStrategy.java

View workflow job for this annotation

GitHub Actions / Verify / ubuntu-latest jdk-17-zulu 3.10.0-rc-1 

unreported exception org.apache.maven.artifact.resolver.ArtifactNotFoundException; must be caught or declared to be thrown

Check failure on line 152 in src/main/java/org/apache/maven/shared/io/location/ArtifactLocatorStrategy.java

View workflow job for this annotation

GitHub Actions / Verify / ubuntu-latest jdk-17-zulu 3.10.0-rc-1 

unreported exception org.apache.maven.artifact.resolver.ArtifactNotFoundException; must be caught or declared to be thrown

if (artifact.getFile() != null) {
location = new ArtifactLocation(artifact, locationSpecification);
Expand All @@ -162,10 +161,6 @@
messageHolder.addMessage(
"Failed to resolve artifact: " + artifact.getId() + " for location: " + locationSpecification,
e);
} catch (ArtifactNotFoundException e) {
messageHolder.addMessage(
"Failed to resolve artifact: " + artifact.getId() + " for location: " + locationSpecification,
e);
}
} else {
messageHolder.addMessage("Invalid artifact specification: \'" + locationSpecification
Expand Down
Loading