fix: remove dead code catch block for ArtifactNotFoundException - #113
Closed
prathamesh04 wants to merge 1 commit into
Closed
fix: remove dead code catch block for ArtifactNotFoundException#113prathamesh04 wants to merge 1 commit into
prathamesh04 wants to merge 1 commit into
Conversation
The ArtifactNotFoundException catch block was unreachable because ArtifactNotFoundException extends ArtifactResolutionException, which is caught first. This removes the dead code and the unused import. Closes apache#92
elharo
approved these changes
Jul 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a dead code issue in
ArtifactLocatorStrategy.java.Problem
The
ArtifactNotFoundExceptioncatch block (lines 165-168) was unreachable becauseArtifactNotFoundExceptionextendsArtifactResolutionException. The first catch block catches all instances, making the second catch block dead code.Solution
Removed the dead catch block and the unused import for
ArtifactNotFoundException.Related Issue
Closes #92
Changes
src/main/java/org/apache/maven/shared/io/location/ArtifactLocatorStrategy.java: Removed dead catch block and unused import