Skip to content

[MSCRIPTING-11] Enhanced script context by MavenSession, MojoExecutio… - #7

Closed
hsynkrtl wants to merge 4 commits into
apache:masterfrom
hsynkrtl:master
Closed

[MSCRIPTING-11] Enhanced script context by MavenSession, MojoExecutio…#7
hsynkrtl wants to merge 4 commits into
apache:masterfrom
hsynkrtl:master

Conversation

@hsynkrtl

@hsynkrtl hsynkrtl commented Jan 26, 2023

Copy link
Copy Markdown

…n, PluginDescriptor and Settings

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Make sure there is a JIRA issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a JIRA issue. Your pull request should address just this issue, without
    pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [MSCRIPTING-XXX] - Fixes bug in ApproximateQuantiles,
    where you replace MSCRIPTING-XXX with the appropriate JIRA issue. Best practice
    is to use the JIRA issue title in the pull request title and in the first line of the
    commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean verify to make sure basic checks pass. A more thorough check will
    be performed on your pull request automatically.
  • You have run the integration tests successfully (mvn -Prun-its clean verify).

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

@bmarwell

bmarwell commented Mar 3, 2024

Copy link
Copy Markdown
Contributor

@hsynkrtl can you please rebase this PR and add a test case?

@bmarwell bmarwell left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs rebase and tests, see #4

…n, PluginDescriptor and Settings

# Conflicts:
#	src/main/java/org/apache/maven/plugins/scripting/EvalMojo.java
dependabot Bot and others added 2 commits August 29, 2024 20:25
Bumps [org.apache.maven:maven-core](https://github.com/apache/maven) from 3.6.3 to 3.8.1.
- [Release notes](https://github.com/apache/maven/releases)
- [Commits](apache/maven@maven-3.6.3...maven-3.8.1)

---
updated-dependencies:
- dependency-name: org.apache.maven:maven-core
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
…-maven-core-3.8.1

Bump org.apache.maven:maven-core from 3.6.3 to 3.8.1
@hsynkrtl
hsynkrtl requested a review from bmarwell August 29, 2024 20:35
@jira-importer

Copy link
Copy Markdown

Resolve #47

@elharo

elharo commented Dec 21, 2025

Copy link
Copy Markdown
Contributor

PR is abandoned and bug was closed as won't fix

@elharo elharo closed this Dec 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants