[MSCRIPTING-11] Lifecycle

[jira-importer]

Hüseyin Kartal opened MSCRIPTING-11 and commented

Make the current maven lifecycle phase available in the groovy script.

---

Affects: 3.0.0

Remote Links:

• GitHub Pull Request #7
  

[jira-importer]

Robert Scholte commented

I don't understand this request? Of course the context can be filled with these things, but every new entity might come with possible security related issues (hence I blocked adding settings, because it gives easy access to credentials).
What is the usecase?

[jira-importer]

Hüseyin Kartal commented

I understand. But credentials can be encrypted in settings if it is a security issue. Anyways i don't rely on "settings". But i need the current maven lifecycle phase which is available in the mojoExecution. Is it ok to add that.

Currently i want to migrate an ant build to maven and have two usecases where i want to use the scripting plugin.

1. I need to call some java classes for generation of sources and resources. For this i want to determine the current lifecycle phase of the maven execution. And because i don't want to fragment the script i need the mojoExecution for that.
2. Some artifacts are not available in repositories. And because i don't want to uses dependencies in system scope i install them within a script into the local repository.

[jira-importer]

Robert Scholte commented

I think in both cases the answer is execution-blocks
For 1: you want a script that looks like:

if ("compile".equals(phase)) { /* do this*/ } else if ("test-compile".equals(phase)) { /* do that*/ }

If that is the case, you'd better do this:

   <build>
  <plugins>
    <plugin>
     <groupId>org.apache.maven.plugins</groupId>
     <artifactId>maven-scripting-plugin</artifactId>
     <version>3.0.0</version>
     <executions>
       <execution>
         <id>compile-script</id>
         <phase>compile</phase>
         <configuration>
           <script><![CDATA[ // I'm in the compile phase' ]]></script>
         </configuration>
       </execution>
       <execution>
         <id>test-compile-script</id>
         <phase>test-compile</phase>
         <configuration>
           <script><![CDATA[ // I'm in the test-compile phase' ]]></script>
         </configuration>
       </execution>
     </executions>
   </plugin>
  </plugins>
</build>

for 2: I would make a profile called "setup", and have a couple of execution blocks using install:install-file

[jira-importer]

Hüseyin Kartal commented

I also want to use the org.apache.maven.shared.incremental.IncrementalBuildHelper in both usescases. To instantiate it MojoExecution, MavenSession and MavenProject needed.

[jira-importer]

Robert Scholte commented

Based on those extra requirements it makes more sense to me to write your own plugin or extension.
I prefer not to turn the scripting-plugin into a swiss army knife.

[jira-importer]

Hüseyin Kartal commented

For what is than the scripting plugin good if i don't have access to the maven context which the requested objects are mandatory part of it. Otherwise anyone can call their scripts outside from maven. I wouldn't call the enhancement making the plugin a swiss knife on the contrary it would become usefull.

[jira-importer]

Robert Scholte commented

The original question to expose the lifecycle or phase will not be supported. By using execution-blocks you already control the phase in which is it executed.