Skip to content

Disable failing arrow_writer benchmark #9638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alamb merged 3 commits into from
Apr 1, 2026
Merged

Disable failing arrow_writer benchmark #9638

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
11d5c37
Disable failing arrow_writer benchmark
alamb Mar 31, 2026
1d4fa9e
Merge remote-tracking branch 'apache/main' into alamb/disable_failing…
alamb Apr 1, 2026
bc08899
Clippy and easier to undersgtand comments
alamb Apr 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions parquet/benches/arrow_writer.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ use arrow::util::bench_util::{create_f16_array, create_f32_array, create_f64_arr
use arrow::{record_batch::RecordBatch, util::data_gen::*};
use arrow_array::RecordBatchOptions;
use parquet::errors::Result;
use parquet::file::properties::{CdcOptions, WriterProperties, WriterVersion};
use parquet::file::properties::{WriterProperties, WriterVersion};

fn create_primitive_bench_batch(
size: usize,
Expand Down Expand Up @@ -420,10 +420,12 @@ fn create_writer_props() -> Vec<(&'static str, WriterProperties)> {
.build();
props.push(("zstd_parquet_2", prop));

let prop = WriterProperties::builder()
.set_content_defined_chunking(Some(CdcOptions::default()))
.build();
props.push(("cdc", prop));
// Disabled until https://github.com/apache/arrow-rs/issues/9637 is fixed

@kszucs kszucs Mar 31, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a comment only change, do I miss something?

@kszucs kszucs Mar 31, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or just GH's syntax highligthing is fooling me?

Image

@HippoBaro HippoBaro Apr 1, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's creating a comment block which encloses the benchmark definition, effectively disabling it.

@alamb alamb Apr 1, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will switch to // comments to make this clearer

//
// let prop = WriterProperties::builder()
// .set_content_defined_chunking(Some(CdcOptions::default()))
// .build();
// props.push(("cdc", prop));

props
}
Expand Down
Loading