Disable failing arrow_writer benchmark - #9638
Merged
alamb merged 3 commits intoApr 1, 2026
Merged
Conversation
This was referenced Mar 31, 2026
alamb
marked this pull request as ready for review
March 31, 2026 20:30
kszucs
reviewed
Mar 31, 2026
| .build(); | ||
| props.push(("zstd_parquet_2", prop)); | ||
|
|
||
| // Disabled until https://github.com/apache/arrow-rs/issues/9637 is fixed |
Member
There was a problem hiding this comment.
Seems like a comment only change, do I miss something?
Member
There was a problem hiding this comment.
Or just GH's syntax highligthing is fooling me?
Contributor
There was a problem hiding this comment.
It's creating a comment block which encloses the benchmark definition, effectively disabling it.
Contributor
Author
There was a problem hiding this comment.
I will switch to // comments to make this clearer
etseidl
approved these changes
Mar 31, 2026
Rich-T-kid
pushed a commit
to Rich-T-kid/arrow-rs
that referenced
this pull request
Jun 2, 2026
# Which issue does this PR close? - Part of apache#9637 # Rationale for this change I can't benchmark the arrow-writer changes in apache#9447 due to hitting a panic: - apache#9637 # What changes are included in this PR? Temporarily disable the cdc benchmarks until the underlying bug is fixed # Are these changes tested? <!-- We typically require tests for all PRs in order to: 1. Prevent the code from being accidentally broken by subsequent changes 2. Serve as another way to document the expected behavior of the code If tests are not included in your PR, please explain why (for example, are they covered by existing tests)? --> # Are there any user-facing changes? <!-- If there are user-facing changes then we may require documentation to be updated before approving the PR. If there are any breaking changes to public APIs, please call them out. -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
I can't benchmark the arrow-writer changes in #9447 due to hitting a panic:
What changes are included in this PR?
Temporarily disable the cdc benchmarks until the underlying bug is fixed
Are these changes tested?
Are there any user-facing changes?