fix(parquet): restore opaque return type for RowSelection::iter - #10450
Merged
Conversation
apache#10141 changed `RowSelection::iter` from `impl Iterator<Item = &RowSelector>` to a named type, `RowSelectionIter<'_>`. Restore the opaque return type so we stay free to change the implementation later. Both match arms are already `std::slice::Iter<'_, RowSelector>`, so `RowSelectionIter` is not needed at all and is removed rather than made private. No behaviour change.
Jefffrey
approved these changes
Jul 28, 2026
hhhizzz
approved these changes
Jul 28, 2026
Contributor
|
thanks @haohuaijin & @hhhizzz |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
RowSelectioncan be backed by aBooleanBuffer#10141, addressing feat(parquet):RowSelectioncan be backed by aBooleanBuffer#10141 (comment)Rationale for this change
#10141 changed
RowSelection::iterfromimpl Iterator<Item = &RowSelector>to a named type,RowSelectionIter<'_>. As @Jefffrey pointed out, the opaque return type is worth keeping so we stay free to change the implementation later.What changes are included in this PR?
RowSelection::iterreturnsimpl Iterator<Item = &RowSelector>again. Both match arms are alreadystd::slice::Iter<'_, RowSelector>, soRowSelectionIteris not needed at all and is removed rather than made private. No behaviour change.Are these changes tested?
Covered by the existing
RowSelectiontests, which calliter()on both backings.cargo test -p parquet --all-featurespasses.Are there any user-facing changes?
No.
RowSelectionIterwas added in #10141 and never released, anditer()keeps theIterator<Item = &RowSelector>contract callers already relied on.