Skip to content
Draft
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 36 additions & 2 deletions arrow/benches/boolean_kernels.rs
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@

#[macro_use]
extern crate criterion;
use criterion::Criterion;
use criterion::{BatchSize, Criterion};

use arrow::util::bench_util::create_boolean_array;

Expand Down Expand Up @@ -79,5 +79,39 @@ fn add_benchmark(c: &mut Criterion) {
c.bench_function("not_slice_24", |b| b.iter(|| bench_not(&array1_sliced_24)));
}

criterion_group!(benches, add_benchmark);
fn add_take_n_true_benchmark(c: &mut Criterion) {
let size = 2usize.pow(13); // 8K

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, as hhhizzz mentioned here, it might be worth benchmarking both small and larger sizes -- say, 32KB and 64KB.

// keep roughly the first half of the set bits
let n = size / 4;
Comment on lines +84 to +85

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: did you mean keep 1/4 of the set bits?


// the clone in each iteration shares the values buffer, so `take_n_true`
// cannot reuse the allocation and must copy the retained prefix
let array = create_boolean_array(size, 0.0, 0.5);
c.bench_function("take_n_true shared", |b| {
b.iter(|| hint::black_box(array.clone().take_n_true(n)))
});

// a fresh array per iteration (built in setup, excluded from timing) has
// an unshared values buffer, allowing the allocation to be reused
let values: Vec<bool> = array.values().iter().collect();
c.bench_function("take_n_true unshared", |b| {
b.iter_batched(
|| BooleanArray::from(values.clone()),
|array| array.take_n_true(n),
BatchSize::SmallInput,
)
});

let array_nulls = create_boolean_array(size, 0.1, 0.5);
c.bench_function("take_n_true nulls shared", |b| {
b.iter(|| hint::black_box(array_nulls.clone().take_n_true(n)))
});

// fewer than n set bits: scans but returns self unchanged
c.bench_function("take_n_true no truncation", |b| {
b.iter(|| hint::black_box(array.clone().take_n_true(size)))
});
}

criterion_group!(benches, add_benchmark, add_take_n_true_benchmark);
criterion_main!(benches);
Loading