Add benchmark for BooleanArray::take_n_true - #10399
Draft
alamb wants to merge 1 commit into
Draft
Conversation
alamb
force-pushed
the
alamb/bench-take-n-true
branch
from
July 20, 2026 21:01
1e0c9ca to
b37b9bb
Compare
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
alamb
force-pushed
the
alamb/bench-take-n-true
branch
from
July 20, 2026 21:11
f17b206 to
46663c5
Compare
Rich-T-kid
approved these changes
Jul 28, 2026
Rich-T-kid
left a comment
Rich-T-kid
left a comment
Contributor
There was a problem hiding this comment.
I know this is marked as a draft but it looks good to me
Comment on lines
+84
to
+85
| // keep roughly the first half of the set bits | ||
| let n = size / 4; |
Contributor
There was a problem hiding this comment.
nit: did you mean keep 1/4 of the set bits?
Rich-T-kid
reviewed
Jul 28, 2026
|
|
||
| criterion_group!(benches, add_benchmark); | ||
| fn add_take_n_true_benchmark(c: &mut Criterion) { | ||
| let size = 2usize.pow(13); // 8K |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
BooleanBuffer::try_into_builderandBooleanBuffer::into_builder_or_clone#10397 (part of Addinto_buildermethods for Arrays #6430)Buffer.into_mutableto reuse the allocation if possible intake_n_true#10251Rationale for this change
BooleanArray::take_n_truehas no benchmark coverage but I am trying to optimize it (see #10397)What changes are included in this PR?
Add new
take_n_truecases in the existingboolean_kernelsbenchmark, on 32768-element arrays:Are these changes tested?
The benchmark compiles and runs (
cargo bench --bench boolean_kernels --features test_utils -- --test).Are there any user-facing changes?
No, benchmark only.