Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions arrow-json/src/reader/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -2903,6 +2903,21 @@ mod tests {
);
}

#[test]
fn test_serialize_f32_into_string() {
// Coercing an f32 into a string column must render the value, not its raw bit pattern.
let field = Field::new("f", DataType::Utf8, true);
let mut decoder = ReaderBuilder::new_with_field(field)
.with_coerce_primitive(true)
.build_decoder()
.unwrap();
decoder.serialize(&[1.5_f32, -2.25_f32]).unwrap();
let batch = decoder.flush().unwrap().unwrap();
let values = batch.column(0).as_string::<i32>();
assert_eq!(values.value(0), "1.5");
assert_eq!(values.value(1), "-2.25");
}

// Parse the given `row` in `struct_mode` as a type given by fields.
//
// If as_struct == true, wrap the fields in a Struct field with name "r".
Expand Down
2 changes: 1 addition & 1 deletion arrow-json/src/reader/string_array.rs
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ impl<O: OffsetSizeTrait> ArrayDecoder for StringArrayDecoder<O> {
builder.append_value(int_formatter.format(n));
}
TapeElement::F32(n) if coerce_primitive => {
builder.append_value(int_formatter.format(n));
builder.append_value(float_formatter.format_finite(f32::from_bits(n)));
}
TapeElement::F64(high) if coerce_primitive => match tape.get(p + 1) {
TapeElement::F32(low) => {
Expand Down
Loading