fix(arrow-json): render coerced f32 as its value in the string decoder - #10386
Merged
Jefffrey merged 1 commit intoJul 20, 2026
Merged
Conversation
Jefffrey
approved these changes
Jul 20, 2026
Contributor
|
thanks @hareshkh |
Contributor
Author
|
Thanks for the super quick turn around @Jefffrey ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
When coercing a float into a string column,
StringArrayDecoderran af32through the integer formatter on its raw bits, so it rendered theu32bit pattern instead of the value (e.g.1.5f32→"1069547520"). The adjacentf64arm andtape.rsalready reconstruct viafrom_bits.What changes are included in this PR?
The
F32arm ofStringArrayDecodernow usesfloat_formatter.format_finite(f32::from_bits(n)), matching thef64arm. Plus a unit test.Are these changes tested?
Yes — new
test_serialize_f32_into_string(fails before the fix, passes after); the fullarrow-jsonsuite passes.Are there any user-facing changes?
Yes (bug fix): an
f32coerced to string now renders its value, not its bit pattern. No API changes. Only reachable viaDecoder::serializewithcoerce_primitive; JSON text decoding was already correct.