Skip to content

Remove always-panicking benchmarks #10384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Jefffrey merged 2 commits into from
Jul 20, 2026
Merged

Remove always-panicking benchmarks #10384

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
656a6e7
Remove always-panicking benchmarks
itsjunetime Jul 13, 2026
3cee113
Remove unused import
itsjunetime Jul 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 0 additions & 17 deletions arrow/benches/concatenate_elements.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ extern crate criterion;
use criterion::Criterion;

use arrow::array::*;
use arrow::datatypes::*;
use arrow::util::bench_util::*;
use arrow_string::concat_elements::concat_elements_dyn;
use std::hint;
Expand Down Expand Up @@ -70,22 +69,6 @@ fn add_benchmark(c: &mut Criterion) {
c.bench_function(&id, |b| b.iter(|| bench_concat(&array, &array)));
}
}

let v1 = create_string_array_with_len::<i32>(10, 0.0, 20);
let v1 = create_dict_from_values::<Int32Type>(1024, 0.0, &v1);
let v2 = create_string_array_with_len::<i32>(10, 0.0, 20);
let v2 = create_dict_from_values::<Int32Type>(1024, 0.0, &v2);
c.bench_function("concat str_dict 1024", |b| {
b.iter(|| bench_concat(&v1, &v2))
});

let v1 = create_string_array_with_len::<i32>(1024, 0.0, 20);
let v1 = create_sparse_dict_from_values::<Int32Type>(1024, 0.0, &v1, 10..20);
let v2 = create_string_array_with_len::<i32>(1024, 0.0, 20);
let v2 = create_sparse_dict_from_values::<Int32Type>(1024, 0.0, &v2, 30..40);
c.bench_function("concat str_dict_sparse 1024", |b| {
b.iter(|| bench_concat(&v1, &v2))
});
}

criterion_group!(benches, add_benchmark);
Expand Down
Loading