Remove always-panicking benchmarks - #10384
Merged
Merged
Conversation
Jefffrey
approved these changes
Jul 20, 2026
Jefffrey
added
the
development-process
Contributor
|
thanks @itsjunetime |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
No attached issue
Rationale for this change
These benchmarks always panic, since calling
arrow_string::concat_elements::concat_elements_dynwithDictionaryArrays always panics.Are these changes tested?
Yes, all tests pass and now a higher percentage of benchmarks run correctly
Are there any user-facing changes?
No, this is all dev-related