Skip to content

[v3-3-test] Fix conn-fields check crash for nested provider packages (#70224) #70279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Lee-W wants to merge 1 commit into
base: v3-3-test
Choose a base branch
from
+20 −2
Open

[v3-3-test] Fix conn-fields check crash for nested provider packages (#70224) #70279

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions providers/atlassian/jira/provider.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,18 @@ connection-types:
- hook-class-name: airflow.providers.atlassian.jira.hooks.jira.JiraHook
hook-name: "JIRA"
connection-type: jira
conn-fields:
verify:
label: Verify SSL
schema:
type:
- boolean
- 'null'
default: true
ui-field-behaviour:
hidden-fields:
- schema
- extra

notifications:
- airflow.providers.atlassian.jira.notifications.jira.JiraNotifier
7 changes: 7 additions & 0 deletions providers/atlassian/jira/src/airflow/providers/atlassian/jira/get_provider_info.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,13 @@ def get_provider_info():
"hook-class-name": "airflow.providers.atlassian.jira.hooks.jira.JiraHook",
"hook-name": "JIRA",
"connection-type": "jira",
"conn-fields": {
"verify": {
"label": "Verify SSL",
"schema": {"type": ["boolean", "null"], "default": True},
}
},
"ui-field-behaviour": {"hidden-fields": ["schema", "extra"]},
}
],
"notifications": ["airflow.providers.atlassian.jira.notifications.jira.JiraNotifier"],
Expand Down
1 change: 0 additions & 1 deletion providers/atlassian/jira/src/airflow/providers/atlassian/jira/hooks/jira.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,6 @@ def get_ui_field_behaviour(cls) -> dict[str, Any]:
"""Return custom UI field behaviour for Atlassian Jira Connection."""
return {
"hidden_fields": ["schema", "extra"],
"relabeling": {},
}


Expand Down
2 changes: 1 addition & 1 deletion scripts/ci/prek/common_prek_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@
AIRFLOW_TASK_SDK_SOURCES_PATH = AIRFLOW_TASK_SDK_ROOT_PATH / "src"

# Here we should add the second level paths that we want to have sub-packages in
KNOWN_SECOND_LEVEL_PATHS = ["apache", "atlassian", "common", "cncf", "dbt", "microsoft"]
KNOWN_SECOND_LEVEL_PATHS = ["apache", "atlassian", "common", "cncf", "dbt", "ibm", "microsoft"]

DEFAULT_PYTHON_MAJOR_MINOR_VERSION = "3.10"

Expand Down