UI: prefer active state over queued when colouring collapsed groups#67543
Open
nathadfield wants to merge 1 commit into
Open
UI: prefer active state over queued when colouring collapsed groups#67543nathadfield wants to merge 1 commit into
nathadfield wants to merge 1 commit into
Conversation
12bf938 to
b6090b8
Compare
a5cca5a to
950e087
Compare
bbovenzi
requested changes
May 26, 2026
Contributor
bbovenzi
left a comment
There was a problem hiding this comment.
We should update the order inSTATE_PRIORITY in parameters.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Collapsed task groups and mapped tasks in the graph and grid views took their badge / border / icon colour from the backend's
agg_state(), which ranksqueued/scheduledahead ofrunning/deferred. A group with onequeuedtask and fiverunningtasks renderedqueued-colouredeven though most of its children were actively executing. The segmented state bar from #61854 already showed the proportional mix correctly, but the surrounding visual elements stayed onagg_state.This PR adds a frontend
getDisplayStatehelper that ranks active/error states ahead of pending states, and routes the dominant colour through it across the five rendering surfaces that consume an aggregate state: the graph node (TaskNode.tsx), grid cell (GridTI.tsx), shared tooltip "State:" line, group/mapped detail-page headers, and the graph MiniMap. The helper returnsnullfor no-status dominants so callers keep their existing no-status placeholder rather than leaking the serialized"None"key into Chakra tokens.The graph state filter (
useGraphFilteredNodes.ts) is also realigned, but to a "matches any child state" predicate rather than the dominant rendering — an operator filtering for "running" expects to find running work even when it's buried inside a fail-dominant group. Leaf tasks still match by single state.Two pre-existing rendering bugs for the
"None"key in the segmented-bar slice and tooltip per-state breakdown are tracked at #67541 with in-code pointers at each affected site.related: #67541
Was generative AI tooling used to co-author this PR?
Generated-by: Claude Code (Opus 4.7) following the guidelines