Fix None child state rendering in UI#67552
Open
Codingaditya17 wants to merge 5 commits into
Open
Conversation
bbovenzi
requested changes
May 26, 2026
Contributor
bbovenzi
left a comment
There was a problem hiding this comment.
It would be better to fix this on the API level. Renaming None to none, and making sure that no_status & none share the same color in theme.ts and the same translation in common.json
Contributor
Author
|
Thanks for the review. I updated the PR to move the normalization to the API layer as suggested. What changed:
Tests run locally:
|
bbovenzi
reviewed
May 26, 2026
bbovenzi
approved these changes
May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes rendering for serialized
Nonechild state keys in the UI.The grid API can return child states like
{"None": 2, "success": 1}. Before this change, the UI used the rawNonekey directly for Chakra color tokens and translations, producingNone.solidandcommon:states.None.This change adds small state normalization helpers and applies them to the two direct
child_statesrender sites:SegmentedStateBar.tsxTaskInstanceTooltip.tsxScope
This PR intentionally only fixes the direct child state breakdown/rendering issue described in #67541. It does not change the dominant state logic handled separately in #67543.
Tests