oncetask: log handler errors from SafeExecute - #20
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When a task handler returns an error, oncetask records the error in the task's
errorsarray in Firestore but does not emit a log line. Handler-error visibility in Cloud Logging therefore depends on each handler logging the error itself. The two completion-adjacent log lines (once_task_firestore.go:292,:319) only fire when the Firestore persistence of the completion itself fails — a different, rarer event — and they usem.ctx, so they don't pick uptaskId/resourceKey(or any caller-attached fields) viaContextHandler.Solution
Emit a single
slog.ErrorContext(ctx, "Handler returned error", "error", err)insideSafeExecutewhen the wrapped function returns an error.SafeExecuteis the chokepoint for all three production handler paths (cancellation, single-task, resource-batch). Thectxpassed in already carriestaskId/resourceKeyviawithTaskContext/withSingleTaskContext/withResourceKeyTaskContext, soContextHandler(oncetask/context_logger.go) auto-injects them and any caller-attached fields ride along.Context
filterAndSpawnOccurrences) doesn't invoke user handlers and already logs its own errors.once_task_firestore.go:307-308is an oncetask-internal bug and already logs itself.SafeExecutecontinues to log atErrorwith the same per-task ctx.