oncetask: inject taskType into log records via ContextHandler - #21
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
ContextHandler(oncetask/context_logger.go) currently auto-injectstaskIdandresourceKeyfrom context but nottaskType. When debugging across Cloud Logging, knowing the task kind is at least as useful as the task ID — it answers "what queue is this?" at a glance, lets you filter to a single handler's logs, and disambiguates errors when many task types share a resource key.Solution
taskTypeContextKey, and haveContextHandler.HandleaddtaskTypeto every log record whose context carries it.withTaskContextto taketaskType string(unexported helper — small ripple). The two batch wrappers (withSingleTaskContext,withResourceKeyTaskContext) passstring(tasks[0].Type). All tasks in a resource-batch share the sameType, so a single value is correct for the batch.once_task_firestore.go(cancellation loop).TestContextHandler_InjectsTaskTypefor coverage.taskTypeis structurally required on every task (it routes to the registered handler and keys the consumer loop), so it is always set unconditionally inwithTaskContext— no empty-check needed.Context
Follows on from #20. With handler errors now logged from
SafeExecuteusing the per-task context, addingtaskTypeto the auto-injected attributes makes those error records (and any handler-emitted logs) self-describing in Cloud Logging.