chore(deps-dev): bump typescript from 5.4.5 to 6.0.3#61
Merged
Conversation
Supersedes the Dependabot PR, which could not rebase after the lockfile regeneration in #59. TypeScript 6.0 required two tsconfig.spec.json fixes: - module 'commonjs' + moduleResolution 'node': the legacy node10 resolution was removed in TS 6; switched to module 'node20' (matching the jsii 6-generated tsconfig). - baseUrl: hard-deprecated in TS 6 (TS5101); removed, with the paths alias made explicitly relative. - types: TS 6 no longer auto-includes @types packages under this setup; declared ['jest', 'node'] explicitly. Previously ts-jest swallowed the TS5101 config error and silently compiled without types. Verified: tsc -p tsconfig.spec.json clean, 34/34 tests, jsii build clean, lint clean. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #13 — Dependabot couldn't rebase it after #59 regenerated the lockfile ("Dependabot can't resolve your JavaScript dependency files").
TypeScript 6.0 needed three
tsconfig.spec.jsonchanges, all rooted in TS 6 breaking changes:moduleResolution: noderemoved in TS 6 → switchedmoduletonode20, matching what jsii 6 generates for the main tsconfig.baseUrlhard-deprecated (TS5101) → removed; the@/*paths alias is now explicitly relative.@typesinclusion under this setup → declared"types": ["jest", "node"]explicitly.Noteworthy failure mode: ts-jest swallowed the TS5101 config error and compiled with a typeless fallback config, so
jestreported "Tests: 0 total" with what looked like a success line. Worth remembering when reading CI logs.Verification
npx tsc -p tsconfig.spec.json --noEmit: cleannpm test: 34/34npm run build(jsii): cleannpm run lint/format:check: cleanCloses #13. With this, #34 has no remaining scope (jsii 6 and TS 6 both merged) and can be closed.
🤖 Generated with Claude Code