Skip to content

fix: remove undeclared source-map-support import from examples (fixes #28)#54

Open
hanu-14 wants to merge 1 commit into
alphacrack:mainfrom
hanu-14:fix/examples-source-map-import
Open

fix: remove undeclared source-map-support import from examples (fixes #28)#54
hanu-14 wants to merge 1 commit into
alphacrack:mainfrom
hanu-14:fix/examples-source-map-import

Conversation

@hanu-14

@hanu-14 hanu-14 commented Jul 19, 2026

Copy link
Copy Markdown

Removes the import 'source-map-support/register' line from examples/basic-usage.ts and examples/blueprints-usage.ts since source-map-support is not a declared dependency.

@hanu-14
hanu-14 requested a review from alphacrack as a code owner July 19, 2026 16:46

@alphacrack alphacrack left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean fix, matches #28 — removing the import is the right call since the examples are documentation, not a runnable app. This PR is the base of your stack (its changes appear in #55#58 too), so it merges first.

@alphacrack

Copy link
Copy Markdown
Owner

Re-checked against the new main: MERGEABLE/CLEAN, no rebase needed. Still the base of the stack (#55#58 carry this change), so this merges first. Ready.

@hanu-14

hanu-14 commented Jul 21, 2026

Copy link
Copy Markdown
Author

Thanks for the review, alphacrack! I appreciate the feedback. The PR is now clean and ready to merge, and I’ll ensure the base of the stack is updated as needed for #55#58.

@hanu-14 hanu-14 closed this Jul 22, 2026
@hanu-14 hanu-14 reopened this Jul 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants