Skip to content

feat: expose bucketArn/bucketName and domain name getters on SecureBucket (fixes #41)#56

Open
hanu-14 wants to merge 2 commits into
alphacrack:mainfrom
hanu-14:feat/securebucket-attribute-getters
Open

feat: expose bucketArn/bucketName and domain name getters on SecureBucket (fixes #41)#56
hanu-14 wants to merge 2 commits into
alphacrack:mainfrom
hanu-14:feat/securebucket-attribute-getters

Conversation

@hanu-14

@hanu-14 hanu-14 commented Jul 19, 2026

Copy link
Copy Markdown

Adds pass-through readonly getters for bucketArn, bucketName, bucketDomainName, and bucketRegionalDomainName on SecureBucket so common attribute access no longer requires .bucket. Includes tests; jsii build and full suite pass.

@hanu-14
hanu-14 requested a review from alphacrack as a code owner July 19, 2026 16:46
@github-actions github-actions Bot added s3 Relates to the S3 SecureBucket resource tests Test coverage and test infrastructure labels Jul 19, 2026

@alphacrack alphacrack left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work — plain get accessors are exactly the jsii-friendly shape (they translate to properties in Python/Java/.NET), the doc comments are consistent with the file's style, and including the two domain-name getters covers the "consider" part of #41.

One non-blocking nit: the second test (resolves getters to the same values as the wrapped bucket) asserts a subset of what the first already covers. Consider dropping it, or making it assert something distinct — e.g. that Token.isUnresolved(bucket.bucketArn) is true, which would prove the getter returns the live CDK token. Fine to address here or not at all.

@alphacrack

Copy link
Copy Markdown
Owner

Re-checked against the new main: MERGEABLE/CLEAN. Two things verified specifically for today's toolchain moves:

  • The plain get accessors compile identically under jsii 6 (now on main) — no jsii-compat concerns.
  • The ESLint 10 migration (chore: migrate to ESLint 10 flat config #59) kept all rules 1:1, so this diff lints clean under the new flat config.

Merges after #54. Ready.

@hanu-14

hanu-14 commented Jul 21, 2026

Copy link
Copy Markdown
Author

Thanks for the thorough review! I appreciate the verification of jsii 6 compatibility and ESLint 10 cleanliness. The diff looks good as-is, and I’ll merge after #54.

@hanu-14 hanu-14 closed this Jul 22, 2026
@hanu-14 hanu-14 reopened this Jul 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

s3 Relates to the S3 SecureBucket resource tests Test coverage and test infrastructure

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants