Skip to content

fix(editor): selection crashes on empty buffer (A6, A7) #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dsent merged 2 commits into from
Jun 30, 2026
Merged

fix(editor): selection crashes on empty buffer (A6, A7) #29

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2545c4f
fix(search): initialize selection in constructor
Vadim1987 Jun 28, 2026
5afeb30
fix(buffer): clamp selection and guard empty content
Vadim1987 Jun 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/model/editor/bufferModel.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,6 +242,9 @@ end

--- @param sel integer
function BufferModel:set_selection(sel)
local max = self:get_content_length() + 1
if not sel or sel < 1 then sel = 1 end
if sel > max then sel = max end
self.selection = sel
end

Expand All @@ -258,7 +261,8 @@ function BufferModel:_get_selected_block()

local sel = self.selection
if sel == self:get_content_length() + 1 then
local ln = self.content:last().pos.fin + 1
local last = self.content:last()
local ln = (last and last.pos.fin or 0) + 1
return Empty(ln)
end
return self.content[sel]
Expand Down
1 change: 1 addition & 0 deletions src/model/editor/searchModel.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ Search = class.create(function(cfg)
input = UserInputModel(cfg, nil, false, 'search'),
searchset = {},
resultset = {},
selection = 1,
visible = ScrollableContent(0, 1, l)
}
end)
Expand Down
Loading