fix(editor): selection crashes on empty buffer (A6, A7)#29
Merged
dsent merged 2 commits intoJun 30, 2026
Conversation
hleb-rubanau
approved these changes
Jun 30, 2026
hleb-rubanau
left a comment
hleb-rubanau
left a comment
Collaborator
There was a problem hiding this comment.
Looks sane to me. I'd recommend to add a small test (so that problem won't get back unnoticed if someone alters the code), but lack of such test does not block the fix itself.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A6: Search never initialized selection in its constructor, so opening search on an empty buffer and pressing up/down did arithmetic on nil. Initialize selection = 1. A7: BufferModel:set_selection took any value unchecked and restore_state feeds a saved selection unconditionally, so a stale selection on an emptied buffer indexed nil via content:last(). Clamp selection to the buffer range, and guard last() for empty content.