Skip to content

fix(project): robust project file loading (A5, C6) #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dsent merged 4 commits into from
Jun 30, 2026
Merged

fix(project): robust project file loading (A5, C6) #27

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1d9de34
fix(lua): return error on non-string code instead of crashing
Vadim1987 Jun 25, 2026
97c28b7
fix(project): report missing main.lua instead of compiling it
Vadim1987 Jun 25, 2026
31700b8
Make error string less generic
dsent Jun 30, 2026
cde9b0b
Better error message (by Copilot)
dsent Jun 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/model/project/project.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -382,7 +382,11 @@ function ProjectService:run(name, env)
p_path, err = self.is_project(ProjectService.path, name)
end
if p_path then
local _, code = self.current:readfile(ProjectService.MAIN)
local ok, code = self.current:readfile(ProjectService.MAIN)
if not ok then return nil, code, p_path end
if type(code) ~= 'string' then
return nil, FS.messages.unreadable(ProjectService.MAIN), p_path
end
local content, c_err = codeload(code, env)
Comment thread
dsent marked this conversation as resolved.
return content, c_err, p_path
end
Expand Down
3 changes: 3 additions & 0 deletions src/util/lua.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,9 @@ end
--- @return function? chunk
--- @return string? err
local codeload = function(code, env)
if type(code) ~= 'string' then
return nil, ('code must be a string (got %s)'):format(type(code))
end
local f, err = loadstring(code)

if not f then return nil, err end
Expand Down
Loading