fix(project): robust project file loading (A5, C6)#27
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR hardens Lua project file loading to avoid crashes and misleading compilation errors when project source cannot be read (e.g., missing main.lua or transient read failures).
Changes:
- Add a defensive guard in
codeloadto avoid callingloadstringwith non-string input. - Fix
ProjectService:runto respectreadfile’s success flag and return the real read error instead of compiling the error message as code.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/util/lua.lua | Adds a type guard before loadstring to prevent crashes on nil/non-string code. |
| src/model/project/project.lua | Checks readfile’s success flag in ProjectService:run to propagate missing/failed read errors correctly. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Collaborator
|
The extra changes suggested by Copilot seem overdefensive and unnecessary to me. I think we should ignore them. If everyone agrees, I will reject-resolve. |
Collaborator
|
@aldum pls confirm |
aldum
approved these changes
Jun 30, 2026
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
dsent
reviewed
Jun 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A5: codeload crashed on non-string input (readfile can yield nil content on read race / missing read / SD eject); guard and return an error instead of loadstring(nil). C6: ProjectService:run discarded the readfile success flag, so a missing main.lua compiled the error message as code; check the flag and return the real message.