Made - #53
Open
maniospas wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added the ability to toggle whether function definitions should be walked or not (maybe class definitions can also be skipped for speedup in the last case?).
Default behavior is to not check for imports within functions, as these do not necessarily create errors. This behavior can be enabled with
-tor--strictas flags.It was not very clear to me how I should write proper tests and check that the changes do not break anything else (the repo was a bit messy there). Only for convenience, I created a directory
tests/test_func_importsand added there my testing scenario:P.S. For testing:
ouro tests/test_func_importswasn't working for me from the top level (I imagine it was considering this as a file?). Similarly, it would have been nice to get an error if a file does not exist.